From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: SDHI and MMCIF with kzm9g-reference
Date: Wed, 06 Mar 2013 11:56:05 +0000 [thread overview]
Message-ID: <20130306115604.GA11979@verge.net.au> (raw)
In-Reply-To: <20130301110802.GB24364@verge.net.au>
On Tue, Mar 05, 2013 at 04:11:39PM +0900, Paul Mundt wrote:
> On Tue, Mar 05, 2013 at 03:56:52PM +0900, Simon Horman wrote:
> > clocksource: sh_cmt: Set initcall level to subsys
> >
> > The reason for this is to ensure that CMT is probed earlier
> > than with its previous initcall level, module init.
> >
> > This came up as a problem with using kzm9g-reference which does
> > not make use of early timers or devices. In that scenario initialisation
> > of SDHI and MMCIF both stall on msleep() calls due to the absence
> > of a initialised clock source.
> >
> > Boot tested on: armadillo800eva, mackerel and kzm9g
> >
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >
> Any change you make for CMT equally applies to TMU and MTU2, and should
> be made at the same time. We do not want these to get out of sync for no
> reason.
Thanks, Magnus also suggested that to me.
I'll send a small series to fix them, CMT and EM_STI.
> Note that mmc is also under subsys, so you are still link order dependent
> there. If you wish to avoid that, it needs to be no later than
> arch_initcall.
It seems that at this time it is the SDHI and MMCIF drivers that are
causing the trouble I described earlier in the thread, not MMC itself. I
have no particular objections to moving the clock sources to arch_initcall.
But subsys_initcall seems sufficient for now.
next prev parent reply other threads:[~2013-03-06 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-01 11:08 SDHI and MMCIF with kzm9g-reference Simon Horman
2013-03-01 11:34 ` Guennadi Liakhovetski
2013-03-01 12:28 ` Simon Horman
2013-03-04 12:55 ` Magnus Damm
2013-03-04 13:00 ` Simon Horman
2013-03-04 13:40 ` Guennadi Liakhovetski
2013-03-04 14:28 ` Magnus Damm
2013-03-05 6:56 ` Simon Horman
2013-03-05 7:11 ` Paul Mundt
2013-03-06 11:56 ` Simon Horman [this message]
2013-03-07 19:00 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130306115604.GA11979@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox