From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 27 Mar 2013 10:47:47 +0000 Subject: Re: [PATCH 1/3] ARM: shmobile: irqpin: fix handling of spurious interrupts in DT case Message-Id: <20130327104747.GE3040@verge.net.au> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, Mar 21, 2013 at 05:05:36PM +0100, Guennadi Liakhovetski wrote: > To disable spurious interrupts, that get triggered on certain hardware, the > irqpin driver masks them on the parent interrupt controller. To specify > such broken devices a .control_parent parameter can be provided in the > platform data. In the DT case we need a property, to do the same. However, > this is not enough to correctly handle spurious interrupts in the DT case. > In the non-DT case all interrupts get mapped statically during probing, > therefore, if a spurious interrupt arrives, it can easily be mapped back > to hardware registers and bits and handled. In the DT case interrupts are > mapped only when a device, using that interrupt is instantiated from DT. > So, spurious interrupts occur unmapped and thus cannot be handled properly. > This patch fixes this by mapping such interrupts as they occur. > > Signed-off-by: Guennadi Liakhovetski Thanks, queued up for v3.10 in the intc-external-irq branch of the renesas tree.