From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3 v2] ARM: shmobile: bockw: add SMSC ethernet support
Date: Tue, 02 Apr 2013 02:24:34 +0000 [thread overview]
Message-ID: <20130402022433.GA4469@verge.net.au> (raw)
In-Reply-To: <87zjxh6b8t.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Apr 01, 2013 at 05:13:10PM -0700, Kuninori Morimoto wrote:
>
> Hi Sergei, Simon
>
> > > chosen {
> > > - bootargs = "console=ttySC0,115200 ignore_loglevel";
> > > + bootargs = "console=ttySC0,115200 ignore_loglevel ip=dhcp root=/dev/nfs";
> > > };
> > >
> > > memory {
> >
> > In my opinion, modifying .dts file should be done in a separate patch.
> (snip)
> > > # CONFIG_SCHED_DEBUG is not set
> > > # CONFIG_DEBUG_BUGVERBOSE is not set
> > > # CONFIG_FTRACE is not set
> > > # CONFIG_ARM_UNWIND is not set
> > > -CONFIG_KEYS=y
> > > -CONFIG_CRYPTO=y
> > > CONFIG_AVERAGE=y
> >
> > In my opinion, modifying bockw_defconfig should be done in a separate
> > patch. Mixing everything up in a signle patch is a bad practice.
>
> It depends on LTSI backport / upstreaming I believe.
> I need Simon's opinion
I have no strong opinions on this, but in general breaking up patches
makes my life easier. So long as the individual patches don't are useful
and don't break anything :^)
next prev parent reply other threads:[~2013-04-02 2:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 7:13 [PATCH 0/3] ARM: shmobile: Add SMSC support on Bock-W Kuninori Morimoto
2013-03-22 7:14 ` [RFC][PATCH 1/3] ARM: shmobile: define PLATFORM_xxx_INFO() Kuninori Morimoto
2013-03-29 8:37 ` Magnus Damm
2013-04-01 0:41 ` Kuninori Morimoto
2013-03-22 7:14 ` [RFC][PATCH 2/3] ARM: shmobile: r8a7778: add r8a7778_init_irq_extpin() Kuninori Morimoto
2013-03-22 7:15 ` [RFC][PATCH 3/3] ARM: shmobile: bockw: add SMSC ethernet support Kuninori Morimoto
2013-03-27 5:34 ` [PATCH 0/3] ARM: shmobile: Add SMSC support on Bock-W Simon Horman
2013-04-01 2:25 ` [PATCH 0/3 v2] " Kuninori Morimoto
2013-04-01 2:26 ` [PATCH 1/3 v2] ARM: shmobile: r8a7778: remove pointless PLATFORM_INFO() Kuninori Morimoto
2013-04-01 2:27 ` [PATCH 2/3 v2] ARM: shmobile: r8a7778: add r8a7778_init_irq_extpin() Kuninori Morimoto
2013-04-01 12:44 ` Sergei Shtylyov
2013-04-02 0:11 ` Kuninori Morimoto
2013-04-01 2:27 ` [PATCH 3/3 v2] ARM: shmobile: bockw: add SMSC ethernet support Kuninori Morimoto
2013-04-01 12:50 ` Sergei Shtylyov
2013-04-02 0:13 ` Kuninori Morimoto
2013-04-02 2:24 ` Simon Horman [this message]
2013-04-02 3:25 ` Kuninori Morimoto
2013-04-10 9:33 ` [PATCH 3/3 v2] ARM: shmobile: bockw: add pinctrl support Kuninori Morimoto
2013-04-02 4:18 ` [PATCH 0/5 v3] ARM: shmobile: Add SMSC support on Bock-W Kuninori Morimoto
2013-04-02 4:19 ` [PATCH 1/5 v3] ARM: shmobile: r8a7778: remove pointless PLATFORM_INFO() Kuninori Morimoto
2013-04-02 4:19 ` [PATCH 2/5 v3] ARM: shmobile: r8a7778: add r8a7778_init_irq_extpin() Kuninori Morimoto
2013-04-02 4:20 ` [PATCH 3/5 v3] ARM: shmobile: bockw: add SMSC ethernet support Kuninori Morimoto
2013-04-02 4:20 ` [PATCH 4/5 v3] ARM: shmobile: bockw: enable network settings on bootargs Kuninori Morimoto
2013-04-02 4:20 ` [PATCH 5/5 v3] ARM: shmobile: bockw: enable SMSC ethernet on defconfig Kuninori Morimoto
2013-04-03 8:19 ` [PATCH 0/5 v3] ARM: shmobile: Add SMSC support on Bock-W Magnus Damm
2013-04-04 6:52 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402022433.GA4469@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).