* [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro
@ 2013-04-03 7:22 Kuninori Morimoto
2013-04-03 13:42 ` Sergei Shtylyov
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-04-03 7:22 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/include/mach/clock.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/include/mach/clock.h b/arch/arm/mach-shmobile/include/mach/clock.h
index 76ac612..8902044 100644
--- a/arch/arm/mach-shmobile/include/mach/clock.h
+++ b/arch/arm/mach-shmobile/include/mach/clock.h
@@ -24,11 +24,11 @@ struct clk name = { \
}
#define SH_FIXED_RATIO_CLK(name, p, r) \
-static SH_FIXED_RATIO_CLKg(name, p, r);
+static SH_FIXED_RATIO_CLKg(name, p, r)
#define SH_FIXED_RATIO_CLK_SET(name, p, m, d) \
SH_CLK_RATIO(name, m, d); \
- SH_FIXED_RATIO_CLK(name, p, name);
+ SH_FIXED_RATIO_CLK(name, p, name)
#define SH_CLK_SET_RATIO(p, m, d) \
{ \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro
2013-04-03 7:22 [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro Kuninori Morimoto
@ 2013-04-03 13:42 ` Sergei Shtylyov
2013-04-04 6:23 ` Simon Horman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2013-04-03 13:42 UTC (permalink / raw)
To: linux-sh
Hello.
On 03-04-2013 11:22, Kuninori Morimoto wrote:
Subject nit: comma is ','. You meant semicolon. ;-)
And you remove ; from two macros, not one.
With that fixed, you can have my:
Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro
2013-04-03 7:22 [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro Kuninori Morimoto
2013-04-03 13:42 ` Sergei Shtylyov
@ 2013-04-04 6:23 ` Simon Horman
2013-12-10 2:34 ` [PATCH] ARM: shmobile: remove unnecessary platform_device as header cleanup Kuninori Morimoto
2013-12-12 12:53 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-04-04 6:23 UTC (permalink / raw)
To: linux-sh
On Wed, Apr 03, 2013 at 05:42:28PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 03-04-2013 11:22, Kuninori Morimoto wrote:
>
> Subject nit: comma is ','. You meant semicolon. ;-)
> And you remove ; from two macros, not one.
> With that fixed, you can have my:
>
> Acked-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> WBR, Sergei
Morimoto-san, could you repost with an updated changelog, title,
and Sergei's ack?
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] ARM: shmobile: remove unnecessary platform_device as header cleanup
2013-04-03 7:22 [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro Kuninori Morimoto
2013-04-03 13:42 ` Sergei Shtylyov
2013-04-04 6:23 ` Simon Horman
@ 2013-12-10 2:34 ` Kuninori Morimoto
2013-12-12 12:53 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-12-10 2:34 UTC (permalink / raw)
To: linux-sh
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
8e0e7aaef3c98c52e85f5640b73ffa82058abcfd
(ARM: shmobile: Drop r8a7779_add_device_to_domain())
removed last user of struct platform_device on this header.
It is no longer needed
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm/mach-shmobile/include/mach/r8a7779.h b/arch/arm/mach-shmobile/include/mach/r8a7779.h
index 5014145..b40e1363 100644
--- a/arch/arm/mach-shmobile/include/mach/r8a7779.h
+++ b/arch/arm/mach-shmobile/include/mach/r8a7779.h
@@ -11,8 +11,6 @@ enum {
HPBDMA_SLAVE_SDHI0_RX,
};
-struct platform_device;
-
struct r8a7779_pm_ch {
unsigned long chan_offs;
unsigned int chan_bit;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: shmobile: remove unnecessary platform_device as header cleanup
2013-04-03 7:22 [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro Kuninori Morimoto
` (2 preceding siblings ...)
2013-12-10 2:34 ` [PATCH] ARM: shmobile: remove unnecessary platform_device as header cleanup Kuninori Morimoto
@ 2013-12-12 12:53 ` Simon Horman
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-12-12 12:53 UTC (permalink / raw)
To: linux-sh
On Mon, Dec 09, 2013 at 06:34:45PM -0800, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> 8e0e7aaef3c98c52e85f5640b73ffa82058abcfd
> (ARM: shmobile: Drop r8a7779_add_device_to_domain())
> removed last user of struct platform_device on this header.
> It is no longer needed
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 --
> 1 file changed, 2 deletions(-)
Thanks, I will queue this up.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-12 12:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-03 7:22 [PATCH] ARM: shmobile: remove unnecessary comma from SH_FIXED_RATIO_CLK() macro Kuninori Morimoto
2013-04-03 13:42 ` Sergei Shtylyov
2013-04-04 6:23 ` Simon Horman
2013-12-10 2:34 ` [PATCH] ARM: shmobile: remove unnecessary platform_device as header cleanup Kuninori Morimoto
2013-12-12 12:53 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).