From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v4] dma: sudmac: add support for SUDMAC
Date: Tue, 09 Apr 2013 10:16:45 +0000 [thread overview]
Message-ID: <20130409101645.GD29186@linux-sh.org> (raw)
In-Reply-To: <5163E470.7010107@renesas.com>
On Tue, Apr 09, 2013 at 06:50:40PM +0900, Shimoda, Yoshihiro wrote:
> Some Renesas USB modules have SUDMAC. This patch supports it using
> the shdma-base driver.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
...
> +#define SUDMAC_MAX_CHANNELS 2
> +
...
> +struct sudmac_device {
> + struct shdma_dev shdma_dev;
> + struct sudmac_chan *chan[SUDMAC_MAX_CHANNELS];
> + struct sudmac_pdata *pdata;
> + void __iomem *chan_reg;
> +};
> +
...
> +struct sudmac_pdata {
> + const struct sudmac_slave_config *slave;
> + int slave_num;
> + const struct sudmac_channel *channel;
> + int channel_num;
> +};
> +
I'm a bit perplexed as to why you have a hardcoded max channel count when
it can all be derived from the platform data in the first place?
next prev parent reply other threads:[~2013-04-09 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 9:50 [PATCH v4] dma: sudmac: add support for SUDMAC Shimoda, Yoshihiro
2013-04-09 10:16 ` Paul Mundt [this message]
2013-04-09 11:31 ` Shimoda, Yoshihiro
2013-04-10 1:12 ` Kuninori Morimoto
2013-04-10 12:08 ` Sergei Shtylyov
2013-04-10 13:09 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409101645.GD29186@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox