Re: [PATCH v2 0/3] sh-pfc: r8a7779: Improve readability with a new macro

[Simon Horman <horms@verge.net.au>]

On 月,  4月 08, 2013 at 12:05:29午後 +0200, Laurent Pinchart wrote:
> Hello,
> 
> This is the second version of the r8a7779 PFC readability improvement patches
> that use a macro to convert from the documentation pin number space to the
> linear pinctrl space.
> 
> Note that patch 1/3 has already been posted as part of the "r8a7790 PFC pinctrl
> and GPIO improvements" patch series. Depending on the merge order one of them
> should be dropped.
> 
> Simon, is there a chance you could queue this to your pinmux branch for v3.10 ?

If it is urgent, yes. Otherwise I'd prefer to wait for v3.11.

In any case, Magnus, can I get a review?


> Changes from v1:
> 
> - Rename the macro to RCAR_GP_PIN
> - Define the macro in a single header file
> 
> Laurent Pinchart (3):
>   gpio-rcar: Add RCAR_GP_PIN macro
>   sh-pfc: r8a7779: Replace hardcoded pin numbers with RCAR_GP_PIN macro
>   ARM: shmobile: marzen: Use RCAR_GP_PIN macro
> 
>  arch/arm/mach-shmobile/board-marzen.c   |   7 +-
>  drivers/pinctrl/sh-pfc/pfc-r8a7779.c    | 294 ++++++++++++++++++--------------
>  include/linux/platform_data/gpio-rcar.h |   2 +
>  3 files changed, 170 insertions(+), 133 deletions(-)
> 
> -- 
> Regards,
> 
> Laurent Pinchart
>