From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [RFC][PATCH 2/4] ARM: shmobile: r8a7778: fixup Ether setup code position
Date: Tue, 09 Apr 2013 15:12:55 +0000 [thread overview]
Message-ID: <20130409151255.GD27787@verge.net.au> (raw)
In-Reply-To: <874nfgb74b.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Apr 09, 2013 at 04:19:16PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09-04-2013 11:59, Simon Horman wrote:
>
> >>Ether setup code position was scattering.
> >>This patch fixes it up
>
> >Thanks, queued-up in the shc-r8a7778 branch.
>
> >>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >>---
> >> arch/arm/mach-shmobile/setup-r8a7778.c | 28 ++++++++++++++--------------
> >> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> >>diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> >>index 30b4a33..d6ee521 100644
> >>--- a/arch/arm/mach-shmobile/setup-r8a7778.c
> >>+++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> >>@@ -80,12 +80,6 @@ static struct sh_timer_config sh_tmu1_platform_data = {
> [...]
> >>+/* Ether */
> >>+static struct resource ether_resources[] = {
> >>+ DEFINE_RES_MEM(0xfde00000, 0x400),
> >>+ DEFINE_RES_IRQ(gic_iid(0x89)),
> >>+};
> >>+
> >>+void __init r8a7778_add_ether_device(struct sh_eth_plat_data *pdata)
> >>+{
> >>+ platform_device_register_resndata(&platform_bus, "sh_eth", -1,
>
> >BTW, s/sh_eth/sh-eth/ ? Also for r8a7778?
>
> Yes, sorry for this mistake, I'll fix it. Unfortunately, I couldn't test it...
No problem, its an easy mistake to make.
prev parent reply other threads:[~2013-04-09 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-09 5:33 [RFC][PATCH 2/4] ARM: shmobile: r8a7778: fixup Ether setup code position Kuninori Morimoto
2013-04-09 7:59 ` Simon Horman
2013-04-09 12:19 ` Sergei Shtylyov
2013-04-09 15:12 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409151255.GD27787@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox