From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Date: Thu, 18 Apr 2013 15:36:11 +0000 Subject: Re: [PATCH v2 1/2] ARM: shmobile: R8A7779: add Ether support Message-Id: <20130418153611.GX14496@n2100.arm.linux.org.uk> List-Id: References: <201304042253.50662.sergei.shtylyov@cogentembedded.com> In-Reply-To: <201304042253.50662.sergei.shtylyov@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, Apr 04, 2013 at 10:53:50PM +0400, Sergei Shtylyov wrote: > +/* Ether */ > +static struct resource ether_resources[] = { > + { > + .start = 0xfde00000, > + .end = 0xfde003ff, > + .flags = IORESOURCE_MEM, > + }, { > + .start = gic_iid(0xb4), > + .flags = IORESOURCE_IRQ, > + }, There are macros for initializing these which have been around for a few years now. Please consider using them in future.