From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code
Date: Thu, 18 Apr 2013 15:44:25 +0000 [thread overview]
Message-ID: <20130418154425.GZ14496@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201304050257.00799.sergei.shtylyov@cogentembedded.com>
On Fri, Apr 05, 2013 at 02:57:00AM +0400, Sergei Shtylyov wrote:
> +/* USB PHY */
> +static struct resource usb_phy_resources[] = {
> + [0] = {
> + .start = 0xffe70000,
> + .end = 0xffe70900 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = 0xfff70000,
> + .end = 0xfff70900 - 1,
> + .flags = IORESOURCE_MEM,
> + },
Please consider using the macros for these initialisers.
> +static struct resource ehci0_resources[] = {
> + [0] = {
> + .start = 0xffe70000,
> + .end = 0xffe70400 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_iid(0x4c),
> + .flags = IORESOURCE_IRQ,
> + },
Ditto.
> +static struct resource ehci1_resources[] = {
> + [0] = {
> + .start = 0xfff70000,
> + .end = 0xfff70400 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_iid(0x4d),
> + .flags = IORESOURCE_IRQ,
> + },
Ditto.
> +static struct resource ohci0_resources[] = {
> + [0] = {
> + .start = 0xffe70400,
> + .end = 0xffe70800 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_iid(0x4c),
> + .flags = IORESOURCE_IRQ,
> + },
Ditto.
> +static struct resource ohci1_resources[] = {
> + [0] = {
> + .start = 0xfff70400,
> + .end = 0xfff70800 - 1,
> + .flags = IORESOURCE_MEM,
> + },
> + [1] = {
> + .start = gic_iid(0x4d),
> + .flags = IORESOURCE_IRQ,
> + },
Ditto.
next prev parent reply other threads:[~2013-04-18 15:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 22:57 [PATCH 1/8] ARM: shmobile:Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code Sergei Shtylyov
2013-04-05 0:41 ` Simon Horman
2013-04-05 15:47 ` Sergei Shtylyov
2013-04-05 18:46 ` Sergei Shtylyov
2013-04-18 15:44 ` Russell King - ARM Linux [this message]
2013-04-18 17:40 ` Sergei Shtylyov
2013-04-19 2:17 ` Simon Horman
2013-04-19 11:44 ` Sergei Shtylyov
2013-04-22 3:45 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130418154425.GZ14496@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).