From: Mark Brown <broonie@kernel.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 2/4] sh-pfc: sh73a0: Add VCCQ MC0 regulator
Date: Thu, 25 Apr 2013 11:07:18 +0000 [thread overview]
Message-ID: <20130425110718.GS5019@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1366840828-17335-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 499 bytes --]
On Thu, Apr 25, 2013 at 12:00:26AM +0200, Laurent Pinchart wrote:
> As the same register is also used for pin control purposes there is no
> way to achieve atomic read/write sequences with a separate regulator
> driver. We thus need to implement the regulator here.
You could use an MMIO regmap providing the performance isn't critical
enough for that to cause problems.
But this looks basically OK if we can't do that for some reason.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-04-25 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 22:00 [PATCH v2 2/4] sh-pfc: sh73a0: Add VCCQ MC0 regulator Laurent Pinchart
2013-04-25 11:07 ` Mark Brown [this message]
2013-04-25 11:18 ` Laurent Pinchart
2013-04-25 12:16 ` Mark Brown
2013-04-25 12:27 ` Laurent Pinchart
2013-04-25 12:37 ` Mark Brown
2013-04-25 13:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425110718.GS5019@opensource.wolfsonmicro.com \
--to=broonie@kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox