From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] irqchip: Add irqchip_init dummy function
Date: Wed, 08 May 2013 16:33:03 +0000 [thread overview]
Message-ID: <201305081833.03716.arnd@arndb.de> (raw)
In-Reply-To: <518A6C05.9030303@cogentembedded.com>
On Wednesday 08 May 2013, Sergei Shtylyov wrote:
> > --- a/include/linux/irqchip.h
> > +++ b/include/linux/irqchip.h
> > @@ -11,6 +11,10 @@
> > #ifndef _LINUX_IRQCHIP_H
> > #define _LINUX_IRQCHIP_H
> >
> > +#ifdef CONFIG_IRQCHIP
> > void irqchip_init(void);
> > +#else
> > +void irqchip_init(void) {};
>
> Semicolon not needed here.
>
> > +#endif
>
More importantly, the function should be marked as "static inline", otherwise
you get a link error if this header is included in more than one place.
Arnd
next prev parent reply other threads:[~2013-05-08 16:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 13:20 [PATCH] irqchip: Add irqchip_init dummy function Bastian Hecht
2013-05-08 15:15 ` Sergei Shtylyov
2013-05-08 16:33 ` Arnd Bergmann [this message]
2013-05-08 18:51 ` Sergei Shtylyov
2013-05-09 3:44 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305081833.03716.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox