From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support
Date: Wed, 22 May 2013 14:32:04 +0000 [thread overview]
Message-ID: <20130522143204.GE32012@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1305171458550.31481@axis700.grange>
On Fri, May 17, 2013 at 03:00:23PM +0200, Guennadi Liakhovetski wrote:
> Hi Simon, Magnus
>
> On Wed, 3 Apr 2013, Simon Horman wrote:
>
> > From: Magnus Damm <damm@opensource.se>
> >
> > Add LAN9220 support to the APE6EVM board using C and DT.
> > At this point the PFC driver lacks DT bindings so to
> > configure the PFC we use PINCTRL in C board code.
> >
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm/boot/dts/r8a73a4-ape6evm.dts | 23 ++++++++++++++++++-
> > arch/arm/mach-shmobile/board-ape6evm.c | 38 ++++++++++++++++++++++++++++++++
> > 2 files changed, 60 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > index 833f703..f603c69 100644
> > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > @@ -16,7 +16,7 @@
> > compatible = "renesas,ape6evm", "renesas,r8a73a4";
> >
> > chosen {
> > - bootargs = "console=ttySC0,115200 ignore_loglevel";
> > + bootargs = "console=ttySC0,115200 ignore_loglevel root=/dev/nfs ip=dhcp";
> > };
> >
> > memory@40000000 {
> > @@ -24,8 +24,29 @@
> > reg = <0 0x40000000 0 0x40000000>;
> > };
> >
> > + ape6evm_fixed_3v3: fixedregulator@0 {
> > + compatible = "regulator-fixed";
> > + regulator-name = "3V3";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-always-on;
> > + };
> > +
> > lbsc {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > +
> > + ethernet@8000000 {
> > + compatible = "smsc,lan9118", "smsc,lan9115";
> > + reg = <0x08000000 0x1000>;
> > + interrupt-parent = <&irqc1>;
> > + interrupts = <8 0x4>;
> > + phy-mode = "mii";
> > + reg-io-width = <4>;
> > + smsc,irq-active-high;
> > + smsc,irq-push-pull;
> > + vdd33a-supply = <&ape6evm_fixed_3v3>;
> > + vddvario-supply = <&ape6evm_fixed_3v3>;
> > + };
> > };
> > };
>
> The above didn't work in my tests without this:
>
> diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> index f603c69..4fb0102 100644
> --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> @@ -33,8 +33,10 @@
> };
>
> lbsc {
> + compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> + ranges = <0 0 0 0x80000000>;
>
> ethernet@8000000 {
> compatible = "smsc,lan9118", "smsc,lan9115";
>
Could you please post this as a formal patch and indicate
if you would like it included as a fix in v3.10 or not?
Also, I am curious to know what your tests are.
next prev parent reply other threads:[~2013-05-22 14:32 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 2:08 [GIT PULL v2] Renesas ARM SoC board updates for v3.10 #3 Simon Horman
2013-04-03 2:08 ` [PATCH 01/11] ARM: shmobile: add R-Car M1A Bock-W platform support Simon Horman
2013-04-03 2:08 ` [PATCH 02/11] ARM: shmobile: kzm9g-reference: add ethernet support Simon Horman
2013-04-03 2:08 ` [PATCH 03/11] ARM: shmobile: APE6EVM base support Simon Horman
2013-04-03 2:08 ` [PATCH 04/11] ARM: shmobile: APE6EVM PFC support Simon Horman
2013-04-03 2:08 ` [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support Simon Horman
2013-05-17 13:00 ` Guennadi Liakhovetski
2013-05-22 14:32 ` Simon Horman [this message]
2013-05-22 17:22 ` Guennadi Liakhovetski
2013-05-25 1:01 ` Simon Horman
2013-05-28 2:45 ` Olof Johansson
2013-05-29 6:26 ` Guennadi Liakhovetski
2013-05-30 4:39 ` Olof Johansson
2013-05-30 5:33 ` Guennadi Liakhovetski
2013-05-30 13:26 ` Arnd Bergmann
2013-04-03 2:08 ` [PATCH 06/11] ARM: shmobile: Initial r8a7790 Lager board support Simon Horman
2013-04-03 2:08 ` [PATCH 07/11] ARM: shmobile: mackerel: SDHI resources do not have to be numbered Simon Horman
2013-04-03 2:08 ` [PATCH 08/11] ARM: shmobile: mackerel: remove OCR masks, where regulators are used Simon Horman
2013-04-03 2:08 ` [PATCH 09/11] ARM: shmobile: mackerel: switch SDHI and MMCIF interfaces to slot-gpio Simon Horman
2013-04-03 2:08 ` [PATCH 10/11] ARM: shmobile: mackerel: add interrupt names for SDHI0 Simon Horman
2013-04-03 2:08 ` [PATCH 11/11] ARM: shmobile: mackerel: clean up MMCIF vs. SDHI1 selection Simon Horman
2013-04-03 6:30 ` [GIT PULL v2] Renesas ARM SoC board updates for v3.10 #3 Olof Johansson
2013-04-04 3:33 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-04-02 5:11 Simon Horman
2013-04-02 5:11 ` [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130522143204.GE32012@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).