From: Olof Johansson <olof@lixom.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/12] ARM: shmobile: r8a7740: Add OF support to initialze the GIC
Date: Tue, 28 May 2013 03:36:06 +0000 [thread overview]
Message-ID: <20130528033606.GH13532@quad.lixom.net> (raw)
In-Reply-To: <1369645193-3595-8-git-send-email-horms+renesas@verge.net.au>
Hi,
On Mon, May 27, 2013 at 05:59:48PM +0900, Simon Horman wrote:
> From: Bastian Hecht <hechtb@gmail.com>
>
> We add a variant to initalize the interrupt controller in case we describe
> the GIC using the Device Tree and not platform data.
>
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/include/mach/r8a7740.h | 1 +
> arch/arm/mach-shmobile/intc-r8a7740.c | 24 ++++++++++++++++++------
> 2 files changed, 19 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/r8a7740.h b/arch/arm/mach-shmobile/include/mach/r8a7740.h
> index abdc4d4..19c0423 100644
> --- a/arch/arm/mach-shmobile/include/mach/r8a7740.h
> +++ b/arch/arm/mach-shmobile/include/mach/r8a7740.h
> @@ -534,6 +534,7 @@ enum {
>
> extern void r8a7740_meram_workaround(void);
> extern void r8a7740_init_irq(void);
> +extern void r8a7740_init_irq_of(void);
> extern void r8a7740_map_io(void);
> extern void r8a7740_add_early_devices(void);
> extern void r8a7740_add_standard_devices(void);
This is not a comment on this patch per se, but this header file should
probably be directly under the mach directory instead of under include/mach.
In particular, if/when the shmobile platforms get converted to
multiplatform, the header file has to move. And I see that most of these
functions are only used locally in that directory anyway.
It'd be nice to see some of that addressed by 3.12 or so, if you have a chance.
-Olof
next prev parent reply other threads:[~2013-05-28 3:36 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 8:59 [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Simon Horman
2013-05-27 8:59 ` [PATCH 01/12] ARM: shmobile: remove ";" from SH_FIXED_RATIO_CLK*() macro Simon Horman
2013-05-27 8:59 ` [PATCH 02/12] ARM: shmobile: r8a7740 pinmux platform device cleanup Simon Horman
2013-05-27 8:59 ` [PATCH 03/12] ARM: shmobile: r8a7740: Add interim sh-eth device name to clocks list Simon Horman
2013-05-27 8:59 ` [PATCH 04/12] ARM: shmobile: r8a7740: Add DT name to clock list for CMT10 Simon Horman
2013-05-28 3:29 ` Olof Johansson
2013-05-28 5:29 ` Simon Horman
2013-05-28 6:22 ` Olof Johansson
2013-05-31 7:57 ` Magnus Damm
2013-05-31 21:39 ` Arnd Bergmann
2013-06-01 4:20 ` Olof Johansson
2013-05-27 8:59 ` [PATCH 05/12] ARM: shmobile: r8a7740: Make private clock arrays static Simon Horman
2013-05-27 8:59 ` [PATCH 06/12] ARM: shmobile: r8a7740: Add I2C DT clock names Simon Horman
2013-05-28 3:30 ` Olof Johansson
2013-05-27 8:59 ` [PATCH 07/12] ARM: shmobile: r8a7740: Add OF support to initialze the GIC Simon Horman
2013-05-28 3:36 ` Olof Johansson [this message]
2013-05-27 8:59 ` [PATCH 08/12] ARM: shmobile: r8a7740: Prepare for reference DT setup Simon Horman
2013-05-27 8:59 ` [PATCH 09/12] ARM: shmobile: r8a7740: Add Suspend-To-RAM A3SM Simon Horman
2013-05-28 3:50 ` Olof Johansson
2013-05-28 5:29 ` Simon Horman
2013-05-28 21:20 ` Bastian Hecht
2013-06-04 5:09 ` Simon Horman
2013-06-04 15:34 ` Bastian Hecht
2013-06-06 1:10 ` Simon Horman
2013-05-27 8:59 ` [PATCH 10/12] ARM: shmobile: r8a7740: Add CPUIdle Simon Horman
2013-05-27 11:03 ` Daniel Lezcano
2013-05-28 3:54 ` Olof Johansson
2013-05-28 6:08 ` Daniel Lezcano
2013-06-04 5:10 ` Simon Horman
2013-05-27 8:59 ` [PATCH 11/12] ARM: shmobile: fix sleep-r8a7740.S miscompiles Simon Horman
2013-05-27 8:59 ` [PATCH 12/12] ARM: shmobile: clock-r8a7740: add TPU PWM support Simon Horman
2013-05-28 3:58 ` [GIT PULL] Renesas ARM based r8a7740 SoC updates for v3.11 Olof Johansson
2013-05-28 5:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528033606.GH13532@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).