From: Olof Johansson <olof@lixom.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/8] ARM: shmobile: sh73a0 pinmux platform device cleanup
Date: Tue, 28 May 2013 04:02:43 +0000 [thread overview]
Message-ID: <20130528040243.GM13532@quad.lixom.net> (raw)
In-Reply-To: <51A36A02.9050200@cogentembedded.com>
On Mon, May 27, 2013 at 06:13:22PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 27-05-2013 13:00, Simon Horman wrote:
>
> >From: Magnus Damm <damm@opensource.se>
>
> >Use DEFINE_RES_MEM() and platform_device_register_simple()
> >to save a couple of lines of code.
>
> >Signed-off-by: Magnus Damm <damm@opensource.se>
> >Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> >---
> > arch/arm/mach-shmobile/setup-sh73a0.c | 25 ++++++-------------------
> > 1 file changed, 6 insertions(+), 19 deletions(-)
>
> >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> >index fdf3894..f8f4261 100644
> >--- a/arch/arm/mach-shmobile/setup-sh73a0.c
> >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> >@@ -61,29 +61,16 @@ void __init sh73a0_map_io(void)
> [...]
> >+/* PFC */
> >+static const struct resource pfc_resources[] = {
>
> Should have been annotated as __initdata... too late, need
> another patch.
See comments on other patches/pull requests, I think there's time to revisit
this. I.e. I'll hold off on pulling this based on the other feedback.
-Olof
next prev parent reply other threads:[~2013-05-28 4:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 9:00 [GIT PULL] Renesas ARM based sh73a0 SoC updates for v3.11 Simon Horman
2013-05-27 9:00 ` [PATCH 1/8] ARM: shmobile: sh73a0 pinmux platform device cleanup Simon Horman
2013-05-27 14:13 ` Sergei Shtylyov
2013-05-28 4:02 ` Olof Johansson [this message]
2013-06-04 5:20 ` Simon Horman
2013-06-04 13:20 ` Simon Horman
2013-06-10 12:31 ` Laurent Pinchart
2013-06-11 4:48 ` Simon Horman
2013-06-19 0:37 ` Laurent Pinchart
2013-05-27 9:00 ` [PATCH 2/8] ARM: shmobile: sh73a0: add support for adjusting CPU frequency Simon Horman
2013-05-27 9:00 ` [PATCH 3/8] ARM: shmobile: sh73a0: add CPUFreq support Simon Horman
2013-05-27 9:00 ` [PATCH 5/8] ARM: shmobile: sh73a0: Remove init_irq declaration in machine description Simon Horman
2013-05-27 9:00 ` [PATCH 6/8] ARM: shmobile: sh73a0: Always use shmobile_setup_delay() Simon Horman
2013-05-27 9:00 ` [PATCH 7/8] ARM: shmobile: sh73a0: do not overwrite all div4 clock operations Simon Horman
2013-05-27 9:00 ` [PATCH 8/8] ARM: shmobile: sh73a0: div4 clocks must check the kick bit before changing rate Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528040243.GM13532@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).