From: Olof Johansson <olof@lixom.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/9] ARM: shmobile: add GPIO IRQ macro
Date: Tue, 28 May 2013 04:07:29 +0000 [thread overview]
Message-ID: <20130528040729.GN13532@quad.lixom.net> (raw)
In-Reply-To: <1369648773-7941-3-git-send-email-horms+renesas@verge.net.au>
On Mon, May 27, 2013 at 06:59:26PM +0900, Simon Horman wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> R-Car series gpio_rcar driver can control GPIO IRQ today.
> It needs base IRQ number for gpio_rcar_config :: .irq_base
> This patch adds macro for GPIO IRQ.
> This patch was tested on Bock-W board
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm/mach-shmobile/include/mach/irqs.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/mach-shmobile/include/mach/irqs.h b/arch/arm/mach-shmobile/include/mach/irqs.h
> index b2074e2..d241bfd 100644
> --- a/arch/arm/mach-shmobile/include/mach/irqs.h
> +++ b/arch/arm/mach-shmobile/include/mach/irqs.h
> @@ -16,4 +16,9 @@
> #define IRQPIN_BASE 2000
> #define irq_pin(nr) ((nr) + IRQPIN_BASE)
>
> +/* GPIO IRQ */
> +#define _GPIO_IRQ_BASE 2500
> +#define GPIO_IRQ_BASE(x) (_GPIO_IRQ_BASE + (32 * x))
> +#define GPIO_IRQ(x, y) (_GPIO_IRQ_BASE + (32 * x) + y)
> +
> #endif /* __ASM_MACH_IRQS_H */
Hmm. It'd be real nice to see some effort on moving this over to sparse
irq instead. That'll be needed for full device tree conversion anyway. And
with that, the static irq bases will be gone, so drivers and some of
the platform code will need to be adjusted accordingly.
-Olof
next prev parent reply other threads:[~2013-05-28 4:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 9:59 [GIT PULL] Renesas ARM based r8a7778 SoC updates for v3.11 Simon Horman
2013-05-27 9:59 ` [PATCH 1/9] ARM: shmobile: use do{ }while() on SH_CLK_SET_RATIO() Simon Horman
2013-05-27 9:59 ` [PATCH 2/9] ARM: shmobile: add GPIO IRQ macro Simon Horman
2013-05-28 4:07 ` Olof Johansson [this message]
2013-05-28 5:53 ` Magnus Damm
2013-05-28 6:18 ` Olof Johansson
2013-05-30 1:32 ` Magnus Damm
2013-05-27 9:59 ` [PATCH 3/9] ARM: shmobile: r8a7778: fixup Ether setup code position Simon Horman
2013-05-27 9:59 ` [PATCH 4/9] ARM: shmobile: r8a7778: fix Ether device name Simon Horman
2013-05-27 9:59 ` [PATCH 5/9] ARM: shmobile: r8a7778: use fixed ratio clock Simon Horman
2013-05-27 9:59 ` [PATCH 6/9] ARM: shmobile: r8a7778: Register PFC device Simon Horman
2013-05-27 9:59 ` [PATCH 7/9] ARM: shmobile: r8a7778: add SDHI clock support Simon Horman
2013-05-27 9:59 ` [PATCH 8/9] ARM: shmobile: r8a7778: Register SDHI device Simon Horman
2013-05-27 9:59 ` [PATCH 9/9] ARM: shmobile: r8a7778: correct model name in Kconfig Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528040729.GN13532@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).