From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: shmobile: r8A7779: fix Ether device name
Date: Tue, 04 Jun 2013 05:13:52 +0000 [thread overview]
Message-ID: <20130604051352.GW23054@verge.net.au> (raw)
In-Reply-To: <20130528040043.GL13532@quad.lixom.net>
On Mon, May 27, 2013 at 09:00:43PM -0700, Olof Johansson wrote:
> Hi,
>
>
> On Mon, May 27, 2013 at 06:00:06PM +0900, Simon Horman wrote:
> > From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > While recasting the commit "ARM: shmobile: R8A7779: add Ether support", I made a
> > typo in the platform device's name: used underscore instead of hyphen.
>
> Minor nit: if this has been merged, then including the SHA is useful too.
Thanks, I have updated the changelog to:
ARM: shmobile: r8A7779: fix Ether device name
While recasting the commit dace48d04dee46a3409d5e13cd98031522e46377
("ARM: shmobile: R8A7779: add Ether support"), I made a
typo in the platform device's name: used underscore instead of hyphen.
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[horms+renesas@verge.net.au Add SHA of referenced commit to changlog]
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
index b0b3948..c14a69b 100644
--- a/arch/arm/mach-shmobile/setup-r8a7779.c
+++ b/arch/arm/mach-shmobile/setup-r8a7779.c
@@ -443,7 +443,7 @@ void __init r8a7779_add_standard_devices(void)
void __init r8a7779_add_ether_device(struct sh_eth_plat_data *pdata)
{
- platform_device_register_resndata(&platform_bus, "sh_eth", -1,
+ platform_device_register_resndata(&platform_bus, "sh-eth", -1,
ether_resources,
ARRAY_SIZE(ether_resources),
pdata, sizeof(*pdata));
next prev parent reply other threads:[~2013-06-04 5:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-27 8:59 [GIT PULL] Renesas ARM based r8a7779 SoC updates for v3.11 Simon Horman
2013-05-27 8:59 ` [PATCH 2/2] ARM: shmobile: r8A7779: fix Ether device name Simon Horman
2013-05-28 4:00 ` Olof Johansson
2013-05-30 12:23 ` Sergei Shtylyov
2013-05-31 2:07 ` Simon Horman
2013-06-04 5:13 ` Simon Horman [this message]
2013-06-05 21:56 ` Sergei Shtylyov
2013-06-05 23:33 ` Simon Horman
2013-06-07 18:52 ` Sergei Shtylyov
2013-05-27 8:59 ` [PATCH 1/2] ARM: shmobile: r8a7779: Add PCIe clocks Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-04-09 17:48 [PATCH 2/2] ARM: shmobile: R8A7779: fix Ether device name Sergei Shtylyov
2013-04-10 0:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130604051352.GW23054@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).