From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 3/3 v3] ARM: shmobile: bockw: add SDHI0 support
Date: Wed, 05 Jun 2013 02:03:35 +0000 [thread overview]
Message-ID: <20130605020334.GD16849@verge.net.au> (raw)
In-Reply-To: <8738uwpavc.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jun 04, 2013 at 05:48:18PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> Thank you for your reply
>
> > > > This patch is directly accessing to PUPR4 register which can
> > > > control SDHI0 CD/WP pin pull-up setting.
> > > > It should be replaced in the future.
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > > ---
> (snip)
> >
> > I have dropped this patch as it currently seems to be causing a build failure.
> > Please resolve this and re-post.
> >
> > CC arch/arm/mach-shmobile/board-bockw.o
> > arch/arm/mach-shmobile/board-bockw.c:60: error: variable ‘sdhi0_info’ has initializer but incomplete type
> > arch/arm/mach-shmobile/board-bockw.c:61: error: unknown field ‘tmio_caps’ specified in initializer
> > arch/arm/mach-shmobile/board-bockw.c:61: warning: excess elements in struct initializer
> > arch/arm/mach-shmobile/board-bockw.c:61: warning: (near initialization for ‘sdhi0_info’)
> > arch/arm/mach-shmobile/board-bockw.c:62: error: unknown field ‘tmio_ocr_mask’ specified in initializer
> > arch/arm/mach-shmobile/board-bockw.c:62: warning: excess elements in struct initializer
> > arch/arm/mach-shmobile/board-bockw.c:62: warning: (near initialization for ‘sdhi0_info’)
> > arch/arm/mach-shmobile/board-bockw.c:63: error: unknown field ‘tmio_flags’ specified in initializer
> > arch/arm/mach-shmobile/board-bockw.c:63: warning: excess elements in struct initializer
> > arch/arm/mach-shmobile/board-bockw.c:63: warning: (near initialization for ‘sdhi0_info’)
> > arch/arm/mach-shmobile/board-bockw.c: In function ‘bockw_init’:
> > arch/arm/mach-shmobile/board-bockw.c:134: error: implicit declaration of function ‘r8a7778_sdhi_init’
>
> Hmm... strange.
> I couldn't get this error/warning.
> I used renesas-next-20130604v2 + above patch,
> but no error
Thanks.
The problem that I was seeing was that I was missing some SoC patches.
I have resolved that and re-queued-up your patch
next prev parent reply other threads:[~2013-06-05 2:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-12 5:38 [PATCH 3/3 v3] ARM: shmobile: bockw: add pinctrl support Kuninori Morimoto
2013-04-16 3:10 ` Simon Horman
2013-04-19 3:09 ` [PATCH 3/3 v3] ARM: shmobile: bockw: add SDHI0 support Kuninori Morimoto
2013-04-22 5:24 ` Simon Horman
2013-04-22 10:11 ` Laurent Pinchart
2013-04-23 2:21 ` Simon Horman
2013-06-04 12:16 ` Simon Horman
2013-06-05 0:48 ` Kuninori Morimoto
2013-06-05 2:03 ` Simon Horman [this message]
2013-06-05 2:22 ` Kuninori Morimoto
2013-08-02 1:03 ` [PATCH 3/3 v3] ARM: shmobile: bockw: add USB Function support Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130605020334.GD16849@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox