From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh-pfc: r8a7778: tidyup MMC_D1 pin
Date: Mon, 17 Jun 2013 07:05:38 +0000 [thread overview]
Message-ID: <20130617070537.GA22689@verge.net.au> (raw)
In-Reply-To: <87fvwo6q8u.wl%kuninori.morimoto.gx@renesas.com>
[ Actually CC Laurent ]
On Wed, Jun 12, 2013 at 05:23:38PM +0900, Simon Horman wrote:
> On Tue, Jun 11, 2013 at 07:02:20PM -0700, Kuninori Morimoto wrote:
> > MMC_D1 is RCAR_GP_PIN(1, 8), not RCAR_GP_PIN(2, 8)
> >
> > Reported-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Laurent, could you please review this?
>
> > ---
> > This patch is based on renesas-next-20130611v2
> >
> > drivers/pinctrl/sh-pfc/pfc-r8a7778.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> > index 1dcbabc..f903910 100644
> > --- a/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> > +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7778.c
> > @@ -1447,11 +1447,11 @@ MMC_PFC_PINS(mmc_ctrl, RCAR_GP_PIN(1, 5), RCAR_GP_PIN(1, 6));
> > MMC_PFC_CTRL(mmc_ctrl, MMC_CLK, MMC_CMD);
> > MMC_PFC_PINS(mmc_data1, RCAR_GP_PIN(1, 7));
> > MMC_PFC_DAT1(mmc_data1, MMC_D0);
> > -MMC_PFC_PINS(mmc_data4, RCAR_GP_PIN(1, 7), RCAR_GP_PIN(2, 8),
> > +MMC_PFC_PINS(mmc_data4, RCAR_GP_PIN(1, 7), RCAR_GP_PIN(1, 8),
> > RCAR_GP_PIN(0, 5), RCAR_GP_PIN(0, 6));
> > MMC_PFC_DAT4(mmc_data4, MMC_D0, MMC_D1,
> > MMC_D2, MMC_D3);
> > -MMC_PFC_PINS(mmc_data8, RCAR_GP_PIN(1, 7), RCAR_GP_PIN(2, 8),
> > +MMC_PFC_PINS(mmc_data8, RCAR_GP_PIN(1, 7), RCAR_GP_PIN(1, 8),
> > RCAR_GP_PIN(0, 5), RCAR_GP_PIN(0, 6),
> > RCAR_GP_PIN(1, 4), RCAR_GP_PIN(1, 0),
> > RCAR_GP_PIN(0, 30), RCAR_GP_PIN(0, 31));
> > --
> > 1.7.9.5
> >
next prev parent reply other threads:[~2013-06-17 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-12 2:02 [PATCH] sh-pfc: r8a7778: tidyup MMC_D1 pin Kuninori Morimoto
2013-06-12 8:23 ` Simon Horman
2013-06-17 7:05 ` Simon Horman [this message]
2013-06-17 10:38 ` Laurent Pinchart
2013-06-18 7:11 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130617070537.GA22689@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox