From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] gpio-rcar: Remove #ifdef CONFIG_OF around OF-specific sections
Date: Tue, 18 Jun 2013 08:02:03 +0000 [thread overview]
Message-ID: <20130618080203.GA4191@verge.net.au> (raw)
In-Reply-To: <2696904.tcjoE5nNPq@avalon>
On Mon, Jun 17, 2013 at 09:21:08PM +0200, Laurent Pinchart wrote:
> On Monday 17 June 2013 23:19:07 Sergei Shtylyov wrote:
> > Hello.
> >
> > On 06/17/2013 11:15 PM, Laurent Pinchart wrote:
> > > All functions and data types used by OF-specific code paths are declared
> > > in <linux/of.h> regardless of CONFIG_OF. Replace the #ifdef CONFIG_OF
> > > guard with a if(IS_SELECTED(CONFIG_OF)) and let the compiler optimize
> >
> > You're using IS_ENABLED() actually.
>
> Oops. We should fix gcc to check the commit messages :-)
>
> Simon, could you fix this while applying, or should I resubmit ?
Please re-spin, thanks.
next prev parent reply other threads:[~2013-06-18 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-17 19:15 [PATCH 0/2] R-Car GPIO fixes Laurent Pinchart
2013-06-17 19:15 ` [PATCH 1/2] gpio-rcar: Reference core gpio documentation in the DT bindings Laurent Pinchart
2013-06-19 19:16 ` Linus Walleij
2013-06-17 19:15 ` [PATCH 2/2] gpio-rcar: Remove #ifdef CONFIG_OF around OF-specific sections Laurent Pinchart
2013-06-17 19:19 ` Sergei Shtylyov
2013-06-17 19:21 ` Laurent Pinchart
2013-06-18 8:02 ` Simon Horman [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-20 13:09 [GIT PULL 0/2] Renesas ARM based SoC GPIO R-Car updates for v3.11 #2 Simon Horman
2013-06-20 13:09 ` [PATCH 2/2] gpio-rcar: Remove #ifdef CONFIG_OF around OF-specific sections Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618080203.GA4191@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox