From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 26 Jun 2013 14:52:52 +0000 Subject: Re: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support Message-Id: <20130626145252.GA4748@verge.net.au> List-Id: References: <1642514.quKgForQrD@amdc1032> In-Reply-To: <1642514.quKgForQrD@amdc1032> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org [ Cc linux-sh and Guennadi ] I have not looked into this closely but it seems to me that it would be more robust to resolve this problem using Kconfig. On Wed, Jun 26, 2013 at 12:02:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > From: Bartlomiej Zolnierkiewicz > Subject: [linux-next PATCH] ARM: shmobile: marzen: defconfig: enable DMA engine support > > Building marzen_defconfig for next-20130626 results in the following > build error: > > drivers/built-in.o: In function `sh_mobile_sdhi_probe': > /home/bzolnier/sam/linux-sprc/drivers/mmc/host/sh_mobile_sdhi.c:170: undefined reference to `shdma_chan_filter' > > Fix it by adding CONFIG_DMADEVICES=y line to marzen_defconfig. This > will result in CONFIG_SH_DMAE_BASE being enabled by default and the > needed code being build. > > Cc: Stephen Rothwell > Cc: Simon Horman > Cc: Magnus Damm > Signed-off-by: Kyungmin Park > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > arch/arm/configs/marzen_defconfig | 1 + > 1 file changed, 1 insertion(+) > > Index: b/arch/arm/configs/marzen_defconfig > =================================> --- a/arch/arm/configs/marzen_defconfig 2013-06-21 12:04:24.813681807 +0200 > +++ b/arch/arm/configs/marzen_defconfig 2013-06-25 16:43:40.730367398 +0200 > @@ -96,6 +96,7 @@ CONFIG_USB_STORAGE=y > CONFIG_NEW_LEDS=y > CONFIG_LEDS_CLASS=y > CONFIG_LEDS_GPIO=y > +CONFIG_DMADEVICES=y > CONFIG_UIO=y > CONFIG_UIO_PDRV_GENIRQ=y > # CONFIG_IOMMU_SUPPORT is not set >