From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/4] ARM: shmobile: r8a7778: add usb phy power control function
Date: Wed, 10 Jul 2013 01:07:41 +0000 [thread overview]
Message-ID: <20130710010741.GH32603@verge.net.au> (raw)
In-Reply-To: <87ehb8th3c.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jul 09, 2013 at 03:52:48PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 09-07-2013 9:52, Kuninori Morimoto wrote:
>
> >USB phy initialisation function is needed from not only
> >USB Host but also USB Function too.
> >This patch adds usb phy common control function.
>
> >Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> > arch/arm/mach-shmobile/setup-r8a7778.c | 35 ++++++++++++++++++++++----------
> > 1 file changed, 24 insertions(+), 11 deletions(-)
>
> >diff --git a/arch/arm/mach-shmobile/setup-r8a7778.c b/arch/arm/mach-shmobile/setup-r8a7778.c
> >index 2a101eb..cd98079 100644
> >--- a/arch/arm/mach-shmobile/setup-r8a7778.c
> >+++ b/arch/arm/mach-shmobile/setup-r8a7778.c
> >@@ -109,29 +109,44 @@ void __init r8a7778_add_usb_phy_device(struct rcar_phy_platform_data *pdata)
> > pdata, sizeof(*pdata));
> > }
> >
> >-/* USB */
>
> Why move this comment?
>
> >-static struct usb_phy *phy;
> >-
> >-static int usb_power_on(struct platform_device *pdev)
> >+static int r8a7778_usb_phy_power(int enable)
>
> Why not 'bool enable'?
Morimoto-san, these requests seem reasonable to me.
Could you update your patch and repost with the rest of the series?
next prev parent reply other threads:[~2013-07-10 1:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-09 5:52 [PATCH 1/4] ARM: shmobile: r8a7778: add usb phy power control function Kuninori Morimoto
2013-07-09 11:52 ` Sergei Shtylyov
2013-07-10 1:07 ` Simon Horman [this message]
2013-07-10 1:11 ` Kuninori Morimoto
2013-07-10 1:27 ` Kuninori Morimoto
2013-08-31 23:15 ` [PATCH 1/4] ARM: shmobile: r8a7778: add Ether DT support Sergei Shtylyov
2013-09-02 13:14 ` Laurent Pinchart
2013-09-02 14:05 ` Sergei Shtylyov
2013-09-02 14:18 ` Laurent Pinchart
2013-09-02 15:32 ` Pawel Moll
2013-09-03 12:11 ` Laurent Pinchart
2013-09-03 13:53 ` Sergei Shtylyov
2013-09-03 15:17 ` Magnus Damm
2013-09-03 18:27 ` Sergei Shtylyov
2013-09-04 5:35 ` Magnus Damm
2013-09-04 9:39 ` Laurent Pinchart
2013-09-05 6:03 ` Simon Horman
2013-10-04 6:43 ` [PATCH 1/4] ARM: shmobile: r8a7778: add I2C clock for DT Kuninori Morimoto
2013-10-08 1:49 ` Simon Horman
2014-01-14 2:25 ` [PATCH 1/4] ARM: shmobile: r8a7778: add audio clock in new style Kuninori Morimoto
2014-07-15 9:16 ` [PATCH 1/4] ARM: shmobile: r8a7778: add SCI clock support for DT Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710010741.GH32603@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).