* [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards
@ 2012-07-05 13:17 Guennadi Liakhovetski
2012-07-06 19:10 ` Rafael J. Wysocki
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Guennadi Liakhovetski @ 2012-07-05 13:17 UTC (permalink / raw)
To: linux-sh
On systems, using regulators to supply power to devices, if the REGULATOR
Kconfig option is disabled, regulator API stubs will be used, which often
suffices to bring a default configuration up. If REGULATOR is enabled but
respective regulator drivers are inactive, the real regulator API calls
will be used, which in the absence of drivers will fail to provide
services. This patch prevents such a problem on sh-mobile boards by
forcing REGULATOR_FIXED_VOLTAGE on if REGULATOR is selected.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
arch/arm/mach-shmobile/Kconfig | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index a2045dc..4a0d632 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -58,6 +58,7 @@ config MACH_G4EVM
bool "G4EVM board"
depends on ARCH_SH7377
select ARCH_REQUIRE_GPIOLIB
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
config MACH_AP4EVB
bool "AP4EVB board"
@@ -65,6 +66,7 @@ config MACH_AP4EVB
select ARCH_REQUIRE_GPIOLIB
select SH_LCD_MIPI_DSI
select SND_SOC_AK4642 if SND_SIMPLE_CARD
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
choice
prompt "AP4EVB LCD panel selection"
@@ -83,6 +85,7 @@ config MACH_AG5EVM
bool "AG5EVM board"
select ARCH_REQUIRE_GPIOLIB
select SH_LCD_MIPI_DSI
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
depends on ARCH_SH73A0
config MACH_MACKEREL
@@ -90,15 +93,18 @@ config MACH_MACKEREL
depends on ARCH_SH7372
select ARCH_REQUIRE_GPIOLIB
select SND_SOC_AK4642 if SND_SIMPLE_CARD
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
config MACH_KOTA2
bool "KOTA2 board"
select ARCH_REQUIRE_GPIOLIB
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
depends on ARCH_SH73A0
config MACH_BONITO
bool "bonito board"
select ARCH_REQUIRE_GPIOLIB
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
depends on ARCH_R8A7740
config MACH_ARMADILLO800EVA
@@ -107,16 +113,19 @@ config MACH_ARMADILLO800EVA
select ARCH_REQUIRE_GPIOLIB
select USE_OF
select SND_SOC_WM8978 if SND_SIMPLE_CARD
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
config MACH_MARZEN
bool "MARZEN board"
depends on ARCH_R8A7779
select ARCH_REQUIRE_GPIOLIB
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
config MACH_KZM9D
bool "KZM9D board"
depends on ARCH_EMEV2
select USE_OF
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
config MACH_KZM9G
bool "KZM-A9-GT board"
@@ -124,6 +133,7 @@ config MACH_KZM9G
select ARCH_REQUIRE_GPIOLIB
select USE_OF
select SND_SOC_AK4642 if SND_SIMPLE_CARD
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
comment "SH-Mobile System Configuration"
--
1.7.2.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards
2012-07-05 13:17 [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards Guennadi Liakhovetski
@ 2012-07-06 19:10 ` Rafael J. Wysocki
2013-07-09 9:07 ` [PATCH] ARM: mach-shmobile: select the fixed regulator driver on BockW Kuninori Morimoto
2013-07-10 1:11 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2012-07-06 19:10 UTC (permalink / raw)
To: linux-sh
On Thursday, July 05, 2012, Guennadi Liakhovetski wrote:
> On systems, using regulators to supply power to devices, if the REGULATOR
> Kconfig option is disabled, regulator API stubs will be used, which often
> suffices to bring a default configuration up. If REGULATOR is enabled but
> respective regulator drivers are inactive, the real regulator API calls
> will be used, which in the absence of drivers will fail to provide
> services. This patch prevents such a problem on sh-mobile boards by
> forcing REGULATOR_FIXED_VOLTAGE on if REGULATOR is selected.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Applied to the board-common branch of the renesas.git tree.
Due to the tree organization, there were two merge conflicts, so please
the resulting 'next' branch for correctness.
Thanks,
Rafael
> ---
> arch/arm/mach-shmobile/Kconfig | 10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> index a2045dc..4a0d632 100644
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -58,6 +58,7 @@ config MACH_G4EVM
> bool "G4EVM board"
> depends on ARCH_SH7377
> select ARCH_REQUIRE_GPIOLIB
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> config MACH_AP4EVB
> bool "AP4EVB board"
> @@ -65,6 +66,7 @@ config MACH_AP4EVB
> select ARCH_REQUIRE_GPIOLIB
> select SH_LCD_MIPI_DSI
> select SND_SOC_AK4642 if SND_SIMPLE_CARD
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> choice
> prompt "AP4EVB LCD panel selection"
> @@ -83,6 +85,7 @@ config MACH_AG5EVM
> bool "AG5EVM board"
> select ARCH_REQUIRE_GPIOLIB
> select SH_LCD_MIPI_DSI
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
> depends on ARCH_SH73A0
>
> config MACH_MACKEREL
> @@ -90,15 +93,18 @@ config MACH_MACKEREL
> depends on ARCH_SH7372
> select ARCH_REQUIRE_GPIOLIB
> select SND_SOC_AK4642 if SND_SIMPLE_CARD
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> config MACH_KOTA2
> bool "KOTA2 board"
> select ARCH_REQUIRE_GPIOLIB
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
> depends on ARCH_SH73A0
>
> config MACH_BONITO
> bool "bonito board"
> select ARCH_REQUIRE_GPIOLIB
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
> depends on ARCH_R8A7740
>
> config MACH_ARMADILLO800EVA
> @@ -107,16 +113,19 @@ config MACH_ARMADILLO800EVA
> select ARCH_REQUIRE_GPIOLIB
> select USE_OF
> select SND_SOC_WM8978 if SND_SIMPLE_CARD
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> config MACH_MARZEN
> bool "MARZEN board"
> depends on ARCH_R8A7779
> select ARCH_REQUIRE_GPIOLIB
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> config MACH_KZM9D
> bool "KZM9D board"
> depends on ARCH_EMEV2
> select USE_OF
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> config MACH_KZM9G
> bool "KZM-A9-GT board"
> @@ -124,6 +133,7 @@ config MACH_KZM9G
> select ARCH_REQUIRE_GPIOLIB
> select USE_OF
> select SND_SOC_AK4642 if SND_SIMPLE_CARD
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> comment "SH-Mobile System Configuration"
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: mach-shmobile: select the fixed regulator driver on BockW
2012-07-05 13:17 [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards Guennadi Liakhovetski
2012-07-06 19:10 ` Rafael J. Wysocki
@ 2013-07-09 9:07 ` Kuninori Morimoto
2013-07-10 1:11 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Kuninori Morimoto @ 2013-07-09 9:07 UTC (permalink / raw)
To: linux-sh
34767f8dccc326026f97cd63f759dd36bd83502d
(ARM: mach-shmobile: select the fixed regulator driver on several boards)
decided to select fixed regulator driver on Kconfig.
BockW follows same style.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
arch/arm/mach-shmobile/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
index 30c571b..90f449e 100644
--- a/arch/arm/mach-shmobile/Kconfig
+++ b/arch/arm/mach-shmobile/Kconfig
@@ -124,6 +124,7 @@ config MACH_BOCKW
depends on ARCH_R8A7778
select ARCH_REQUIRE_GPIOLIB
select RENESAS_INTC_IRQPIN
+ select REGULATOR_FIXED_VOLTAGE if REGULATOR
select USE_OF
config MACH_MARZEN
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: select the fixed regulator driver on BockW
2012-07-05 13:17 [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards Guennadi Liakhovetski
2012-07-06 19:10 ` Rafael J. Wysocki
2013-07-09 9:07 ` [PATCH] ARM: mach-shmobile: select the fixed regulator driver on BockW Kuninori Morimoto
@ 2013-07-10 1:11 ` Simon Horman
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-07-10 1:11 UTC (permalink / raw)
To: linux-sh
On Tue, Jul 09, 2013 at 02:07:13AM -0700, Kuninori Morimoto wrote:
> 34767f8dccc326026f97cd63f759dd36bd83502d
> (ARM: mach-shmobile: select the fixed regulator driver on several boards)
> decided to select fixed regulator driver on Kconfig.
> BockW follows same style.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/mach-shmobile/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-shmobile/Kconfig b/arch/arm/mach-shmobile/Kconfig
> index 30c571b..90f449e 100644
> --- a/arch/arm/mach-shmobile/Kconfig
> +++ b/arch/arm/mach-shmobile/Kconfig
> @@ -124,6 +124,7 @@ config MACH_BOCKW
> depends on ARCH_R8A7778
> select ARCH_REQUIRE_GPIOLIB
> select RENESAS_INTC_IRQPIN
> + select REGULATOR_FIXED_VOLTAGE if REGULATOR
> select USE_OF
>
> config MACH_MARZEN
Thanks, I have queued this up for v3.12 in the boards branch.
It should appear in renesas-next-20130710
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-07-10 1:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-05 13:17 [PATCH] ARM: mach-shmobile: select the fixed regulator driver on several boards Guennadi Liakhovetski
2012-07-06 19:10 ` Rafael J. Wysocki
2013-07-09 9:07 ` [PATCH] ARM: mach-shmobile: select the fixed regulator driver on BockW Kuninori Morimoto
2013-07-10 1:11 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).