From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs
Date: Wed, 10 Jul 2013 01:18:08 +0000 [thread overview]
Message-ID: <20130710011807.GQ32603@verge.net.au> (raw)
In-Reply-To: <874nc3w7ln.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Jul 09, 2013 at 06:02:00PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> > > > index cc4c872..b58c1a9 100644
> > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c
> > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> > > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = {
> > > > { .compatible = "renesas,shmobile-sdhi" },
> > > > { .compatible = "renesas,sh7372-sdhi" },
> > > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], },
> > > > {},
> > >
> > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT".
> > > Could you plase add r8a7778 / r8a7779 here ?
> > >
> > > # or we can use common compatible name for it ?
> >
> > Hi Guennadi,
> >
> > could you please address Morimoto-san's review?
>
> He did it on
>
> Subject: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs
> Date: Tue, 9 Jul 2013 09:43:40 +0200 (CEST)
Thanks for pointing that out. Somehow I missed it.
prev parent reply other threads:[~2013-07-10 1:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 15:54 [PATCH v3 0/7] ARM: shmobile: DMAC, MMCIF and SDHI for H2 and APE6 Guennadi Liakhovetski
2013-07-08 15:54 ` [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Guennadi Liakhovetski
2013-07-09 6:09 ` Kuninori Morimoto
2013-07-10 0:38 ` Simon Horman
2013-07-10 1:02 ` Kuninori Morimoto
2013-07-10 1:18 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130710011807.GQ32603@verge.net.au \
--to=horms@verge.net.au \
--cc=cjb@laptop.org \
--cc=g.liakhovetski+renesas@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).