* [PATCH v3 0/7] ARM: shmobile: DMAC, MMCIF and SDHI for H2 and APE6 @ 2013-07-08 15:54 Guennadi Liakhovetski 2013-07-08 15:54 ` [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Guennadi Liakhovetski 0 siblings, 1 reply; 6+ messages in thread From: Guennadi Liakhovetski @ 2013-07-08 15:54 UTC (permalink / raw) To: linux-sh Cc: Magnus Damm, Simon Horman, Guennadi Liakhovetski, linux-mmc, Chris Ball These patches add support for DMA, MMCIF and SDHI controllers to non-DT APE6EVM and Lager board implementations, and MMCIF and SDHI DT templates for APE6 and H2 SoCs. A note concerning SDHI OF compatibility strings. Patch 5 of this series adds OF compatibility strings for sh73a0, r8a73a4, r8a7790 to make it possible to use correct SoC names instead of a supposedly compatible one. Patches 6 and 7 then use those names in SDHI DT templates on r8a73a4 and r8a7790. This doesn't directly impose a commit order dependency, since those templates are added in a disabled state. Therefore these patches can be pushed upstream via different git-trees. Only when specific boards enable SDHI interfaces in their .dts files, only then will it be important to have both respective patches in the kernel: the drivers/mmc patch and the respective SoC .dtsi patch. It is therefore proposed to push these patches to 3.12 and to begin enabling SDHI interfaces in respective board .dtsi files from 3.13. Also note, that sh73a0 is already using "renesas,r8a7740-sdhi" compatibility in its .dtsi. After patch 5 this still will work, but it also will become possible to use a more obvious "renesas,sh73a0-sdhi" OF compatibility string. Developed and tested on top of Simon's renesas.git next snapshot of 08.07.2013. Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com> Cc: linux-mmc@vger.kernel.org Cc: Chris Ball <cjb@laptop.org> Guennadi Liakhovetski (7): ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it ARM: shmobile: ape6evm: add MMCIF support ARM: shmobile: ape6evm: add SDHI interfaces ARM: shmobile: lager: add MMCIF support mmc: SDHI: add DT compatibility strings for further SoCs ARM: shmobile: r8a73a4: add MMCIF and SDHI DT templates ARM: shmobile: r8a7790: add MMCIF and SDHI DT templates arch/arm/boot/dts/r8a73a4.dtsi | 45 ++++++++++++ arch/arm/boot/dts/r8a7790.dtsi | 54 +++++++++++++++ arch/arm/mach-shmobile/board-ape6evm.c | 81 ++++++++++++++++++++++ arch/arm/mach-shmobile/board-lager.c | 31 +++++++++ arch/arm/mach-shmobile/clock-r8a73a4.c | 4 +- arch/arm/mach-shmobile/include/mach/r8a73a4.h | 9 +++ arch/arm/mach-shmobile/setup-r8a73a4.c | 90 +++++++++++++++++++++++++ drivers/mmc/host/sh_mobile_sdhi.c | 3 + 8 files changed, 316 insertions(+), 1 deletions(-) -- 1.7.2.5 Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs 2013-07-08 15:54 [PATCH v3 0/7] ARM: shmobile: DMAC, MMCIF and SDHI for H2 and APE6 Guennadi Liakhovetski @ 2013-07-08 15:54 ` Guennadi Liakhovetski 2013-07-09 6:09 ` Kuninori Morimoto 0 siblings, 1 reply; 6+ messages in thread From: Guennadi Liakhovetski @ 2013-07-08 15:54 UTC (permalink / raw) To: linux-sh Cc: Magnus Damm, Simon Horman, Guennadi Liakhovetski, linux-mmc, Chris Ball Add further OF compatibility strings to the SDHI driver to be able to precisely control driver's behaviour on each of them. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com> Cc: linux-mmc@vger.kernel.org Cc: Chris Ball <cjb@laptop.org> --- As explained in patch 0/7, this patch can be pushed separately via the mmc git-tree. drivers/mmc/host/sh_mobile_sdhi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c index cc4c872..b58c1a9 100644 --- a/drivers/mmc/host/sh_mobile_sdhi.c +++ b/drivers/mmc/host/sh_mobile_sdhi.c @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { { .compatible = "renesas,shmobile-sdhi" }, { .compatible = "renesas,sh7372-sdhi" }, { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, {}, }; MODULE_DEVICE_TABLE(of, sh_mobile_sdhi_of_match); -- 1.7.2.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs 2013-07-08 15:54 ` [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Guennadi Liakhovetski @ 2013-07-09 6:09 ` Kuninori Morimoto 2013-07-10 0:38 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Kuninori Morimoto @ 2013-07-09 6:09 UTC (permalink / raw) To: Guennadi Liakhovetski Cc: linux-sh, Magnus Damm, Simon Horman, Guennadi Liakhovetski, linux-mmc, Chris Ball Hi Guennadi > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > index cc4c872..b58c1a9 100644 > --- a/drivers/mmc/host/sh_mobile_sdhi.c > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > { .compatible = "renesas,shmobile-sdhi" }, > { .compatible = "renesas,sh7372-sdhi" }, > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > {}, According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". Could you plase add r8a7778 / r8a7779 here ? # or we can use common compatible name for it ? Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs 2013-07-09 6:09 ` Kuninori Morimoto @ 2013-07-10 0:38 ` Simon Horman 2013-07-10 1:02 ` Kuninori Morimoto 0 siblings, 1 reply; 6+ messages in thread From: Simon Horman @ 2013-07-10 0:38 UTC (permalink / raw) To: Kuninori Morimoto Cc: Guennadi Liakhovetski, linux-sh, Magnus Damm, Guennadi Liakhovetski, linux-mmc, Chris Ball On Mon, Jul 08, 2013 at 11:09:07PM -0700, Kuninori Morimoto wrote: > > Hi Guennadi > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > index cc4c872..b58c1a9 100644 > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > { .compatible = "renesas,shmobile-sdhi" }, > > { .compatible = "renesas,sh7372-sdhi" }, > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > {}, > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > Could you plase add r8a7778 / r8a7779 here ? > > # or we can use common compatible name for it ? Hi Guennadi, could you please address Morimoto-san's review? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs 2013-07-10 0:38 ` Simon Horman @ 2013-07-10 1:02 ` Kuninori Morimoto 2013-07-10 1:18 ` Simon Horman 0 siblings, 1 reply; 6+ messages in thread From: Kuninori Morimoto @ 2013-07-10 1:02 UTC (permalink / raw) To: Simon Horman Cc: Guennadi Liakhovetski, linux-sh, Magnus Damm, Guennadi Liakhovetski, linux-mmc, Chris Ball Hi Simon > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > > index cc4c872..b58c1a9 100644 > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > > { .compatible = "renesas,shmobile-sdhi" }, > > > { .compatible = "renesas,sh7372-sdhi" }, > > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > {}, > > > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > > Could you plase add r8a7778 / r8a7779 here ? > > > > # or we can use common compatible name for it ? > > Hi Guennadi, > > could you please address Morimoto-san's review? He did it on Subject: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Date: Tue, 9 Jul 2013 09:43:40 +0200 (CEST) Best regards --- Kuninori Morimoto ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs 2013-07-10 1:02 ` Kuninori Morimoto @ 2013-07-10 1:18 ` Simon Horman 0 siblings, 0 replies; 6+ messages in thread From: Simon Horman @ 2013-07-10 1:18 UTC (permalink / raw) To: Kuninori Morimoto Cc: Guennadi Liakhovetski, linux-sh, Magnus Damm, Guennadi Liakhovetski, linux-mmc, Chris Ball On Tue, Jul 09, 2013 at 06:02:00PM -0700, Kuninori Morimoto wrote: > > Hi Simon > > > > > diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c > > > > index cc4c872..b58c1a9 100644 > > > > --- a/drivers/mmc/host/sh_mobile_sdhi.c > > > > +++ b/drivers/mmc/host/sh_mobile_sdhi.c > > > > @@ -130,6 +130,9 @@ static const struct of_device_id sh_mobile_sdhi_of_match[] = { > > > > { .compatible = "renesas,shmobile-sdhi" }, > > > > { .compatible = "renesas,sh7372-sdhi" }, > > > > { .compatible = "renesas,r8a7740-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,sh73a0-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,r8a73a4-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > + { .compatible = "renesas,r8a7790-sdhi", .data = &sh_mobile_sdhi_of_cfg[0], }, > > > > {}, > > > > > > According to HW people, latest Renesas chip needs "TMIO_MMC_HAS_IDLE_WAIT". > > > Could you plase add r8a7778 / r8a7779 here ? > > > > > > # or we can use common compatible name for it ? > > > > Hi Guennadi, > > > > could you please address Morimoto-san's review? > > He did it on > > Subject: [PATCH v4 5/7] mmc: SDHI: add DT compatibility strings for further SoCs > Date: Tue, 9 Jul 2013 09:43:40 +0200 (CEST) Thanks for pointing that out. Somehow I missed it. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-07-10 1:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-08 15:54 [PATCH v3 0/7] ARM: shmobile: DMAC, MMCIF and SDHI for H2 and APE6 Guennadi Liakhovetski 2013-07-08 15:54 ` [PATCH v3 5/7] mmc: SDHI: add DT compatibility strings for further SoCs Guennadi Liakhovetski 2013-07-09 6:09 ` Kuninori Morimoto 2013-07-10 0:38 ` Simon Horman 2013-07-10 1:02 ` Kuninori Morimoto 2013-07-10 1:18 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).