From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth
Date: Wed, 17 Jul 2013 23:15:45 +0000 [thread overview]
Message-ID: <20130717231545.GD8154@verge.net.au> (raw)
In-Reply-To: <87bo69fqds.wl%kuninori.morimoto.gx@renesas.com>
On Fri, Jul 12, 2013 at 03:20:52PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 11-07-2013 15:39, Sergei Shtylyov wrote:
>
> >>No one is using sh_eth on r8a7779 board.
> >>remove it
>
> This may yet change (depends on information/support from
> Renesas), so this is a bit premature. And there's no r8a7779 board,
> there's Marzen (of the supported now boards).
>
> >>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> > NAK.
>
> I've added it not to be removed 2 releases later. Quit creating
> churn please.
Is there any planned usage for this code, in say the next 3 releases?
If not I'm inclined to accept this patch. As its not being exercised it
could easily bit-rot. And it could easily be re-added if it is needed.
next prev parent reply other threads:[~2013-07-17 23:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 8:32 [PATCH 08/11] ARM: shmobile: r8a7779: cleanup registration of sh_eth Kuninori Morimoto
2013-07-11 11:39 ` Sergei Shtylyov
2013-07-12 11:20 ` Sergei Shtylyov
2013-07-17 23:15 ` Simon Horman [this message]
2013-07-18 11:47 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717231545.GD8154@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).