From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/11] ARM: shmobile: r8a7778: cleanup registration of sh_eth
Date: Fri, 19 Jul 2013 02:30:17 +0000 [thread overview]
Message-ID: <20130719023017.GH4403@verge.net.au> (raw)
In-Reply-To: <87li5dfqft.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Jul 18, 2013 at 03:54:33PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 18-07-2013 3:11, Simon Horman wrote:
>
> >>>>>sh_eth driver which needs platform data at the time of
> >>>>>registration is used from BockW only.
> >>>>>Now, ARM/shmobile aims to support DT,
> >>>>>and the C code base board support will be removed in the future.
> >>>>>The driver registration method which needs platform data
> >>>>>and which is not shared complicates codes.
> >>>>>This patch registers it on board code as cleanup C code
>
> >>>>>Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> >>>> NAK.
>
> >>>Please provide some reasoning for your objection to this change.
> >>>Likewise for other patches in this series to which you have replied
> >>>in the same manner. I for one do not understand what it is you object to.
>
> >> Sorry, I was just out of words when I saw this. I for one do not
> >>understand how this change will help the DT support and to me it
> >>seems no more than a pointless churn and step backward from what we
> >>had. Under no circumstances I will accept this change -- I'm totally
> >>opposed to the idea of moving the SoC devices to the board code.
>
> >Hi,
>
> >I believe that the crux of your concern is that the way that
> >SH ethernet support has been added recently is to place SoC portions
> >in setup-xxx.c and board-specific portions into board-YYY.c
>
> Not only Ether but all the SoC devices. Hence were the NAKs for other patches.
I believe that I agree with your concerns.
Morimoto-san, could you drop these cleanup patches?
next prev parent reply other threads:[~2013-07-19 2:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 8:31 [PATCH 01/11] ARM: shmobile: r8a7778: cleanup registration of sh_eth Kuninori Morimoto
2013-07-11 11:25 ` Sergei Shtylyov
2013-07-12 0:56 ` Simon Horman
2013-07-12 11:05 ` Sergei Shtylyov
2013-07-17 23:11 ` Simon Horman
2013-07-18 1:52 ` Kuninori Morimoto
2013-07-18 2:30 ` Simon Horman
2013-07-18 6:35 ` Kuninori Morimoto
2013-07-18 11:54 ` Sergei Shtylyov
2013-07-18 12:26 ` Sergei Shtylyov
2013-07-19 2:30 ` Simon Horman [this message]
2013-07-24 4:45 ` Magnus Damm
2013-07-24 12:58 ` Sergei Shtylyov
2013-07-24 14:13 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130719023017.GH4403@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).