From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 24 Jul 2013 07:23:58 +0000 Subject: Re: [PATCH 01/19] ARM: shmobile: r8a73a4: Add pin control device to device tree Message-Id: <20130724072358.GB17045@verge.net.au> List-Id: References: <803d319cb2fb41e646669061b45701f3ea78e611.1374625203.git.horms+renesas@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, Jul 24, 2013 at 08:11:33AM +0200, Guennadi Liakhovetski wrote: > Hi Simon > > On Wed, 24 Jul 2013, Simon Horman wrote: > > > From: Laurent Pinchart > > > > Add a pfc node to the r8a73a4 device tree. > > > > Signed-off-by: Laurent Pinchart > > [g.liakhovetski+renesas@gmail.com use 2 nodes for address and size] > > it's actually "cells," not "nodes." Thanks. I'd like to leave the comment as is unless there is a more compelling reason to re-base the pull-request. > Thanks > Guennadi > > > Signed-off-by: Guennadi Liakhovetski > > Signed-off-by: Simon Horman > > --- > > arch/arm/boot/dts/r8a73a4.dtsi | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm/boot/dts/r8a73a4.dtsi b/arch/arm/boot/dts/r8a73a4.dtsi > > index 4ff2019..b886afd 100644 > > --- a/arch/arm/boot/dts/r8a73a4.dtsi > > +++ b/arch/arm/boot/dts/r8a73a4.dtsi > > @@ -85,4 +85,11 @@ > > interrupt-parent = <&gic>; > > interrupts = <0 69 4>; > > }; > > + > > + pfc: pfc@e6050000 { > > + compatible = "renesas,pfc-r8a73a4"; > > + reg = <0 0xe6050000 0 0x9000>; > > + gpio-controller; > > + #gpio-cells = <2>; > > + }; > > }; > > -- > > 1.8.2.1 > > > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >