From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: marzen: Switch to DT_MACHINE_START
Date: Wed, 24 Jul 2013 08:46:38 +0000 [thread overview]
Message-ID: <20130724084637.GA5774@verge.net.au> (raw)
In-Reply-To: <20130724073952.GD17045@verge.net.au>
On Wed, Jul 24, 2013 at 04:39:53PM +0900, Simon Horman wrote:
> On Wed, Jul 24, 2013 at 04:30:42PM +0900, Magnus Damm wrote:
> > From: Magnus Damm <damm@opensource.se>
> >
> > Convert the marzen board to use DT_MACHINE_START. With this in
> > place all mach-shmobile boards use DT_MACHINE_START. Also, this
> > makes it possible for the r8a7779 SMP code to use DT for CPUs.
> >
> > So appended DTB is the way forward on this board.
>
> Please supply a patch to update the defconfig accordingly.
In the course of testing this patch I created
a patch to update the defconfig. I will post it with
a patch to use DT for SMP but I have some questions about this patch.
It seems to me that the following is also needed:
* Select USE_OF in Kconfig
* Provide dt_compat in DT_MACHINE_START
* Provide r8a7779-marzen dts
I have a revised version of this patch which does the above.
But I wanted to check with you that I am on the right track
before posting it.
Also, I think that once sh73a0 and r8a7779 uses DT for SMP we can remove
shmobile_smp_init_cpus(). As you have posted a patch for sh73a0 I have
prepated a patch for r8a7779 I have also prepared a patch to remove
shmobile_smp_init_cpus().
My plan is to post all relevant patches as a series once
my questions above are resolved.
> > Signed-off-by: Magnus Damm <damm@opensource.se>
> > ---
> >
> > Written on top of renesas-devel-20130724
> >
> > arch/arm/mach-shmobile/board-marzen.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- 0001/arch/arm/mach-shmobile/board-marzen.c
> > +++ work/arch/arm/mach-shmobile/board-marzen.c 2013-07-24 15:45:39.000000000 +0900
> > @@ -238,7 +238,7 @@ static void __init marzen_init(void)
> > platform_add_devices(marzen_devices, ARRAY_SIZE(marzen_devices));
> > }
> >
> > -MACHINE_START(MARZEN, "marzen")
> > +DT_MACHINE_START(MARZEN, "marzen")
> > .smp = smp_ops(r8a7779_smp_ops),
> > .map_io = r8a7779_map_io,
> > .init_early = r8a7779_add_early_devices,
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-07-24 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-24 7:30 [PATCH] ARM: shmobile: marzen: Switch to DT_MACHINE_START Magnus Damm
2013-07-24 7:39 ` Simon Horman
2013-07-24 8:46 ` Simon Horman [this message]
2013-07-24 10:00 ` Magnus Damm
2013-07-25 2:03 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724084637.GA5774@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).