From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings
Date: Tue, 30 Jul 2013 02:15:46 +0000 [thread overview]
Message-ID: <20130730021545.GA31126@verge.net.au> (raw)
In-Reply-To: <87bo5mrzcc.wl%kuninori.morimoto.gx@renesas.com>
On Sun, Jul 28, 2013 at 05:20:43PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > The following message is printed on the BOCK-W kernel bootup:
> >
> > > sh-pfc pfc-r8a7778: invalid group "sdhi0" for function "sdhi0"
> >
> > > In addition, SD card cannot be detected. The reason is apparently that commit
> > > ca7bb309485e4ec89a9addd47bea (ARM: shmobile: bockw: add SDHI0 support) matched
> > > the previous version of commit 564617d2f92473031d035deb273da5 (sh-pfc: r8a7778:
> > > add SDHI support).
> >
> > > Add the missing pin groups according to the BOCK-W board schematics.
> >
> > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >
> > > ---
> > > The patch is atop of Simon's 'renesas.git' repo, 'renesas-devel-20130726' tag.
> >
> > It also applies to the current Linus' tree cleanly. Please push it for 3.11.
> >
> > WBR, Sergei
>
> Something happen on patch.
That something was probably me :(
> Linux/master branch seems have old verion.
>
> ---- linux/master : old version --------------------------
> commit ca7bb309485e4ec89a9addd47beaa1d079841b7d
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Wed Apr 17 05:17:56 2013 +0000
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ----------------------------------------------------------
>
> This is the correct/latest version
>
> ----- correct version ---------------------------------------------
> commit c2ee46ab49ce3bb5a60b36940e70355beb409acf
> Author: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Date: Thu Apr 18 20:09:32 2013 -0700
>
> ARM: shmobile: bockw: add SDHI0 support
>
> This patch is directly accessing to PUPR4 register which can
> control SDHI0 CD/WP pin pull-up setting.
> It should be replaced in the future.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> -------------------------------------------------------------------
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, I have queued this up for v3.11 in the fixes-for-v3.11 branch.
prev parent reply other threads:[~2013-07-30 2:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 23:46 [PATCH] ARM: shmobile: BOCK-W: fix SDHI0 PFC settings Sergei Shtylyov
2013-07-26 23:55 ` Sergei Shtylyov
2013-07-29 0:20 ` Kuninori Morimoto
2013-07-30 2:15 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730021545.GA31126@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox