From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 31 Jul 2013 00:29:44 +0000 Subject: Re: [PATCH 5/5] ARM: shmobile: ape6evm: add SDHI interfaces Message-Id: <20130731002944.GD17209@verge.net.au> List-Id: References: <51F7B822.7020404@cogentembedded.com> In-Reply-To: <51F7B822.7020404@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Tue, Jul 30, 2013 at 04:57:06PM +0400, Sergei Shtylyov wrote: > Hello. > > On 30-07-2013 13:00, Simon Horman wrote: > > >From: Guennadi Liakhovetski > > >Add support for SDHI0 and SDHI1 on APE6EVM in PIO mode only. > > >Signed-off-by: Guennadi Liakhovetski > >Signed-off-by: Simon Horman > >--- > > arch/arm/mach-shmobile/board-ape6evm.c | 50 +++++++++++++++++++++++++++++++++- > > 1 file changed, 49 insertions(+), 1 deletion(-) > > >diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c > >index 8c7529c..ccf8b04 100644 > >--- a/arch/arm/mach-shmobile/board-ape6evm.c > >+++ b/arch/arm/mach-shmobile/board-ape6evm.c > [...] > >@@ -75,6 +82,29 @@ static struct resource mmcif0_resources[] = { > > DEFINE_RES_IRQ(gic_spi(169)), > > }; > > > >+/* SDHI0 */ > >+static struct sh_mobile_sdhi_info sdhi0_pdata = { > >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE, > >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ, > >+}; > >+ > >+static struct resource sdhi0_resources[] = { > >+ DEFINE_RES_MEM_NAMED(0xee100000, 0x100, "SDHI0"), > >+ DEFINE_RES_IRQ(gic_spi(165)), > >+}; > >+ > >+/* SDHI1 */ > >+static struct sh_mobile_sdhi_info sdhi1_pdata = { > >+ .tmio_flags = TMIO_MMC_HAS_IDLE_WAIT | TMIO_MMC_WRPROTECT_DISABLE, > >+ .tmio_caps = MMC_CAP_SD_HIGHSPEED | MMC_CAP_SDIO_IRQ | > >+ MMC_CAP_NEEDS_POLL, > >+}; > >+ > >+static struct resource sdhi1_resources[] = { > >+ DEFINE_RES_MEM_NAMED(0xee120000, 0x100, "SDHI1"), > >+ DEFINE_RES_IRQ(gic_spi(166)), > >+}; > >+ > > All of the above are lacking '__initdata' annothation (the > resources and platform data will be kmemdup()'ed when registering > the platform devices). Too bad I've noticed this too late... Thanks Sergei. Guennadi, as I have already queued-up this patch could you please make an incremental patch that adds __initdata to the above structures? > > >@@ -124,6 +166,12 @@ static void __init ape6evm_add_standard_devices(void) > > platform_device_register_resndata(&platform_bus, "sh_mmcif", 0, > > mmcif0_resources, ARRAY_SIZE(mmcif0_resources), > > &mmcif0_pdata, sizeof(mmcif0_pdata)); > >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 0, > >+ sdhi0_resources, ARRAY_SIZE(sdhi0_resources), > >+ &sdhi0_pdata, sizeof(sdhi0_pdata)); > >+ platform_device_register_resndata(&platform_bus, "sh_mobile_sdhi", 1, > >+ sdhi1_resources, ARRAY_SIZE(sdhi1_resources), > >+ &sdhi1_pdata, sizeof(sdhi1_pdata)); > > } > > WBR, Sergei > > -- > To unsubscribe from this list: send the line "unsubscribe linux-sh" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >