From: Magnus Damm <magnus.damm@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix memblock_reserve() to include stext
Date: Wed, 31 Jul 2013 05:58:07 +0000 [thread overview]
Message-ID: <20130731055807.14054.70106.sendpatchset@w520> (raw)
From: Magnus Damm <damm@opensource.se>
This fix for the ARM architecture will include stext
in the memblock_reserve() call to make sure that the
following symbols are not overwritten (from System.map):
c0008000 T _text
c0008000 T stext
...
c0008138 T secondary_startup
...
c0009000 T _stext
With this patch applied CPU Hotplug starts working
again. Without this patch code in secondary_startup
never gets reached as expected.
This issue started triggering on kernels later than
v3.10 - perhaps a side effect of the CPU Hotplug init
section rework - so this is a fix for v3.11-rc.
Tested on the sh73a0 KZM9G board with CPU Hotplug:
# echo 0 > /sys/devices/system/cpu/cpu1/online
CPU1: shutdown
# echo 1 > /sys/devices/system/cpu/cpu1/online
CPU1: Booted secondary processor
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/mm/init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/arch/arm/mm/init.c
+++ work/arch/arm/mm/init.c 2013-07-31 14:17:49.000000000 +0900
@@ -346,7 +346,7 @@ void __init arm_memblock_init(struct mem
#ifdef CONFIG_XIP_KERNEL
memblock_reserve(__pa(_sdata), _end - _sdata);
#else
- memblock_reserve(__pa(_stext), _end - _stext);
+ memblock_reserve(__pa(_text), _end - _text);
#endif
#ifdef CONFIG_BLK_DEV_INITRD
if (phys_initrd_size &&
next reply other threads:[~2013-07-31 5:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 5:58 Magnus Damm [this message]
2013-07-31 9:43 ` [PATCH] ARM: Fix memblock_reserve() to include stext Russell King - ARM Linux
2013-07-31 19:34 ` Magnus Damm
2013-07-31 19:39 ` Russell King - ARM Linux
2013-08-01 7:34 ` Simon Horman
2013-08-01 12:58 ` Paul Gortmaker
2013-08-02 1:32 ` Simon Horman
2013-08-02 3:24 ` Magnus Damm
2013-08-02 9:26 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731055807.14054.70106.sendpatchset@w520 \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).