From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 3/3] ARM: shmobile: lager: enable nfsroot in DTS
Date: Thu, 01 Aug 2013 08:02:28 +0000 [thread overview]
Message-ID: <20130801080226.GF15265@verge.net.au> (raw)
In-Reply-To: <87bo5h3lb3.wl%kuninori.morimoto.gx@renesas.com>
On Thu, Aug 01, 2013 at 12:46:44AM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > Now that Ether support has been added to the lager board
> > it is possible to use nfsroot. This configuration is
> > in line with that of other shmobile boards.
> >
> > Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> (snip)
> > chosen {
> > - bootargs = "console=ttySC6,115200 ignore_loglevel";
> > + bootargs = "console=ttySC6,115200 ignore_loglevel root=/dev/nfs ip=dhcp nfsroot=,rsize@96,wsize@96 rw";
>
> Could you please add why this "rsize/wsize" settings
> are needed on bootargs ?
> (other shmobile board's dts file doesn't have these)
>
> And, I guess r8a7790-lager.dts/r8a7790.dts doesn't have
> "sh-eth" driver DT settings, (or I'm missing ?)
> but you added network/nfsroot settings on bootargs.
> It is OK for me, but for what ?
I think it is copy-paste noise.
I'll remove them.
next prev parent reply other threads:[~2013-08-01 8:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 9:09 [PATCH v6 0/3] ARM: shmobile: lager: enable Ether Simon Horman
2013-07-30 9:09 ` [PATCH v6 1/3] ARM: shmobile: r8a7790: clocks for Ether support Simon Horman
2013-07-30 9:09 ` [PATCH v6 2/3] ARM: shmobile: lager: enable Ether Simon Horman
2013-08-01 7:40 ` Kuninori Morimoto
2013-08-01 8:02 ` Simon Horman
2013-07-30 9:09 ` [PATCH v6 3/3] ARM: shmobile: lager: enable nfsroot in DTS Simon Horman
2013-08-01 7:46 ` Kuninori Morimoto
2013-08-01 8:02 ` Simon Horman [this message]
2013-08-06 1:07 ` Simon Horman
2013-08-06 2:18 ` Kuninori Morimoto
2013-08-06 2:29 ` Simon Horman
2013-08-06 2:58 ` Kuninori Morimoto
2013-08-06 3:15 ` [PATCH 0/2] ARM: shmobile: remove nfsroot settings Kuninori Morimoto
2013-08-06 3:17 ` [PATCH 1/2] ARM: shmobile: armadillo800eva: remove nfsroot settings from bootargs Kuninori Morimoto
2013-08-06 3:17 ` [PATCH 2/2] ARM: shmobile: kzm9d: " Kuninori Morimoto
2013-08-06 6:11 ` [PATCH 0/2] ARM: shmobile: remove nfsroot settings Kuninori Morimoto
2013-08-06 8:23 ` Simon Horman
2013-08-06 8:26 ` Kuninori Morimoto
2013-08-06 8:37 ` Simon Horman
2013-08-01 7:23 ` [PATCH v6 0/3] ARM: shmobile: lager: enable Ether Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801080226.GF15265@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).