* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast [not found] <20130904080151.24562.91334.sendpatchset@w520> @ 2013-09-04 8:31 ` Simon Horman 2013-09-04 8:37 ` Simon Horman 1 sibling, 0 replies; 8+ messages in thread From: Simon Horman @ 2013-09-04 8:31 UTC (permalink / raw) To: Magnus Damm Cc: linux-kernel, johnstultz, linux, arnd, linux-sh, sboyd, rob.herring, olof, santosh.shilimkar, grant.likely, tglx On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Update the STI driver by setting cpu_possible_mask to make EMEV2 > SMP work as expected together with the ARM broadcast timer. > > This breakage was introduced by: > > f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event > > Without this fix SMP operation is broken on EMEV2 since no > broadcast timer interrupts trigger on the secondary CPU cores. > > Signed-off-by: Magnus Damm <damm@opensource.se> > --- > > Thanks to feedback from Stephen Boyd this is is a reworked version of: > [PATCH] clocksource: em_sti: Adjust clock event rating to fix SMP broadcast > > drivers/clocksource/em_sti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Simon Horman <horms+renesas@verge.net.au> I will let this sit for a few days to see if there is any further feedback. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast [not found] <20130904080151.24562.91334.sendpatchset@w520> 2013-09-04 8:31 ` [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast Simon Horman @ 2013-09-04 8:37 ` Simon Horman 2013-09-04 8:44 ` Daniel Lezcano 1 sibling, 1 reply; 8+ messages in thread From: Simon Horman @ 2013-09-04 8:37 UTC (permalink / raw) To: Magnus Damm Cc: linux-kernel, Daniel Lezcano, linux, arnd, linux-sh, sboyd, rob.herring, olof, santosh.shilimkar, grant.likely, tglx [ Droped johnstultz@linaro.org CC, the address seems to bounce Added Daniel Lezcano CC, I believe he handles clocksource these days ] On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote: > From: Magnus Damm <damm@opensource.se> > > Update the STI driver by setting cpu_possible_mask to make EMEV2 > SMP work as expected together with the ARM broadcast timer. > > This breakage was introduced by: > > f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event > > Without this fix SMP operation is broken on EMEV2 since no > broadcast timer interrupts trigger on the secondary CPU cores. > > Signed-off-by: Magnus Damm <damm@opensource.se> Tested-by: Simon Horman <horms+renesas@verge.net.au> I will let this sit for a few days to see if there is any further feedback. > --- > > Thanks to feedback from Stephen Boyd this is is a reworked version of: > [PATCH] clocksource: em_sti: Adjust clock event rating to fix SMP broadcast > > drivers/clocksource/em_sti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- 0001/drivers/clocksource/em_sti.c > +++ work/drivers/clocksource/em_sti.c 2013-09-04 16:51:42.000000000 +0900 > @@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s > ced->name = dev_name(&p->pdev->dev); > ced->features = CLOCK_EVT_FEAT_ONESHOT; > ced->rating = 200; > - ced->cpumask = cpumask_of(0); > + ced->cpumask = cpu_possible_mask; > ced->set_next_event = em_sti_clock_event_next; > ced->set_mode = em_sti_clock_event_mode; > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-04 8:37 ` Simon Horman @ 2013-09-04 8:44 ` Daniel Lezcano 2013-09-04 16:29 ` Stephen Boyd 0 siblings, 1 reply; 8+ messages in thread From: Daniel Lezcano @ 2013-09-04 8:44 UTC (permalink / raw) To: Simon Horman Cc: Magnus Damm, linux-kernel, linux, arnd, linux-sh, sboyd, rob.herring, olof, santosh.shilimkar, grant.likely, tglx On 09/04/2013 10:37 AM, Simon Horman wrote: > [ Droped johnstultz@linaro.org CC, the address seems to bounce The address is john.stultz@linaro.org > Added Daniel Lezcano CC, I believe he handles clocksource these days ] Right. > On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote: >> From: Magnus Damm <damm@opensource.se> >> >> Update the STI driver by setting cpu_possible_mask to make EMEV2 >> SMP work as expected together with the ARM broadcast timer. >> >> This breakage was introduced by: >> >> f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event >> >> Without this fix SMP operation is broken on EMEV2 since no >> broadcast timer interrupts trigger on the secondary CPU cores. >> >> Signed-off-by: Magnus Damm <damm@opensource.se> > > Tested-by: Simon Horman <horms+renesas@verge.net.au> > > I will let this sit for a few days to see if there is any further feedback. > >> --- >> >> Thanks to feedback from Stephen Boyd this is is a reworked version of: >> [PATCH] clocksource: em_sti: Adjust clock event rating to fix SMP broadcast >> >> drivers/clocksource/em_sti.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> --- 0001/drivers/clocksource/em_sti.c >> +++ work/drivers/clocksource/em_sti.c 2013-09-04 16:51:42.000000000 +0900 >> @@ -301,7 +301,7 @@ static void em_sti_register_clockevent(s >> ced->name = dev_name(&p->pdev->dev); >> ced->features = CLOCK_EVT_FEAT_ONESHOT; >> ced->rating = 200; >> - ced->cpumask = cpumask_of(0); >> + ced->cpumask = cpu_possible_mask; >> ced->set_next_event = em_sti_clock_event_next; >> ced->set_mode = em_sti_clock_event_mode; >> >> -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-04 8:44 ` Daniel Lezcano @ 2013-09-04 16:29 ` Stephen Boyd 2013-09-05 7:33 ` Simon Horman 0 siblings, 1 reply; 8+ messages in thread From: Stephen Boyd @ 2013-09-04 16:29 UTC (permalink / raw) To: Daniel Lezcano Cc: Simon Horman, Magnus Damm, linux-kernel, linux, arnd, linux-sh, rob.herring, olof, santosh.shilimkar, grant.likely, tglx On 09/04/13 01:44, Daniel Lezcano wrote: > >> On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote: >>> From: Magnus Damm <damm@opensource.se> >>> >>> Update the STI driver by setting cpu_possible_mask to make EMEV2 >>> SMP work as expected together with the ARM broadcast timer. >>> >>> This breakage was introduced by: >>> >>> f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event >>> >>> Without this fix SMP operation is broken on EMEV2 since no >>> broadcast timer interrupts trigger on the secondary CPU cores. >>> >>> Signed-off-by: Magnus Damm <damm@opensource.se> >> Tested-by: Simon Horman <horms+renesas@verge.net.au> >> >> I will let this sit for a few days to see if there is any further feedback. Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-04 16:29 ` Stephen Boyd @ 2013-09-05 7:33 ` Simon Horman 0 siblings, 0 replies; 8+ messages in thread From: Simon Horman @ 2013-09-05 7:33 UTC (permalink / raw) To: Stephen Boyd Cc: Daniel Lezcano, Magnus Damm, linux-kernel, linux, arnd, linux-sh, rob.herring, olof, santosh.shilimkar, grant.likely, tglx On Wed, Sep 04, 2013 at 09:29:53AM -0700, Stephen Boyd wrote: > On 09/04/13 01:44, Daniel Lezcano wrote: > > > >> On Wed, Sep 04, 2013 at 05:01:51PM +0900, Magnus Damm wrote: > >>> From: Magnus Damm <damm@opensource.se> > >>> > >>> Update the STI driver by setting cpu_possible_mask to make EMEV2 > >>> SMP work as expected together with the ARM broadcast timer. > >>> > >>> This breakage was introduced by: > >>> > >>> f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event > >>> > >>> Without this fix SMP operation is broken on EMEV2 since no > >>> broadcast timer interrupts trigger on the secondary CPU cores. > >>> > >>> Signed-off-by: Magnus Damm <damm@opensource.se> > >> Tested-by: Simon Horman <horms+renesas@verge.net.au> > >> > >> I will let this sit for a few days to see if there is any further feedback. > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Thanks, I have queue this up. I will let it sit in next for a little bit and then forward it on to Daniel. ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Renesas clocksource fixes for v3.12
@ 2013-09-18 20:01 Simon Horman
2013-09-18 20:01 ` [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast Simon Horman
0 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2013-09-18 20:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Daniel,
please consider this clocksource fix for v3.12.
This pull request is based on renesas-clocksource-for-v3.12
which I believe you have previously pulled.
The following changes since commit 172705f8a40b6e72c53f8cceda079504ed71c4e0:
clocksource: em_sti: Convert to devm_* managed helpers (2013-08-05 10:47:10 +0900)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-clocksource-fixes-for-v3.12
for you to fetch changes up to 7b096b40c9d3d2abb6bb747dd148c50c076c2e89:
clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast (2013-09-05 14:47:53 +0900)
----------------------------------------------------------------
Renesas clocksource fixes for v3.12
* em_sti: Set cpu_possible_mask to fix SMP broadcast
This resolves a regression introduced by
f7db706 ("ARM: 7674/1: smp: Avoid dummy clockevent being preferred over
real hardware clock-event").
This problem has been present since v3.9-rc4.
----------------------------------------------------------------
Magnus Damm (1):
clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast
drivers/clocksource/em_sti.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-18 20:01 [PATCH] Renesas clocksource fixes for v3.12 Simon Horman @ 2013-09-18 20:01 ` Simon Horman 2013-09-25 21:19 ` Daniel Lezcano 0 siblings, 1 reply; 8+ messages in thread From: Simon Horman @ 2013-09-18 20:01 UTC (permalink / raw) To: linux-arm-kernel From: Magnus Damm <damm@opensource.se> Update the STI driver by setting cpu_possible_mask to make EMEV2 SMP work as expected together with the ARM broadcast timer. This breakage was introduced by: f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event Without this fix SMP operation is broken on EMEV2 since no broadcast timer interrupts trigger on the secondary CPU cores. Signed-off-by: Magnus Damm <damm@opensource.se> Tested-by: Simon Horman <horms+renesas@verge.net.au> Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> --- drivers/clocksource/em_sti.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c index b9c81b7..3a5909c 100644 --- a/drivers/clocksource/em_sti.c +++ b/drivers/clocksource/em_sti.c @@ -301,7 +301,7 @@ static void em_sti_register_clockevent(struct em_sti_priv *p) ced->name = dev_name(&p->pdev->dev); ced->features = CLOCK_EVT_FEAT_ONESHOT; ced->rating = 200; - ced->cpumask = cpumask_of(0); + ced->cpumask = cpu_possible_mask; ced->set_next_event = em_sti_clock_event_next; ced->set_mode = em_sti_clock_event_mode; -- 1.8.4 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-18 20:01 ` [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast Simon Horman @ 2013-09-25 21:19 ` Daniel Lezcano 2013-09-25 23:43 ` Simon Horman 0 siblings, 1 reply; 8+ messages in thread From: Daniel Lezcano @ 2013-09-25 21:19 UTC (permalink / raw) To: linux-arm-kernel On 09/18/2013 10:01 PM, Simon Horman wrote: > From: Magnus Damm <damm@opensource.se> > > Update the STI driver by setting cpu_possible_mask to make EMEV2 > SMP work as expected together with the ARM broadcast timer. > > This breakage was introduced by: > > f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event > > Without this fix SMP operation is broken on EMEV2 since no > broadcast timer interrupts trigger on the secondary CPU cores. > > Signed-off-by: Magnus Damm <damm@opensource.se> > Tested-by: Simon Horman <horms+renesas@verge.net.au> > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- Thanks ! Applied to my tree as 3.12 fix. -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast 2013-09-25 21:19 ` Daniel Lezcano @ 2013-09-25 23:43 ` Simon Horman 0 siblings, 0 replies; 8+ messages in thread From: Simon Horman @ 2013-09-25 23:43 UTC (permalink / raw) To: linux-arm-kernel On Wed, Sep 25, 2013 at 11:19:04PM +0200, Daniel Lezcano wrote: > On 09/18/2013 10:01 PM, Simon Horman wrote: > > From: Magnus Damm <damm@opensource.se> > > > > Update the STI driver by setting cpu_possible_mask to make EMEV2 > > SMP work as expected together with the ARM broadcast timer. > > > > This breakage was introduced by: > > > > f7db706 ARM: 7674/1: smp: Avoid dummy clockevent being preferred over real hardware clock-event > > > > Without this fix SMP operation is broken on EMEV2 since no > > broadcast timer interrupts trigger on the secondary CPU cores. > > > > Signed-off-by: Magnus Damm <damm@opensource.se> > > Tested-by: Simon Horman <horms+renesas@verge.net.au> > > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org> > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > --- > > Thanks ! Applied to my tree as 3.12 fix. Thanks! ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2013-09-25 23:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130904080151.24562.91334.sendpatchset@w520>
2013-09-04 8:31 ` [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast Simon Horman
2013-09-04 8:37 ` Simon Horman
2013-09-04 8:44 ` Daniel Lezcano
2013-09-04 16:29 ` Stephen Boyd
2013-09-05 7:33 ` Simon Horman
2013-09-18 20:01 [PATCH] Renesas clocksource fixes for v3.12 Simon Horman
2013-09-18 20:01 ` [PATCH] clocksource: em_sti: Set cpu_possible_mask to fix SMP broadcast Simon Horman
2013-09-25 21:19 ` Daniel Lezcano
2013-09-25 23:43 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).