From: Simon Horman <horms@verge.net.au>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Subject: Re: [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface
Date: Wed, 25 Sep 2013 04:51:53 +0000 [thread overview]
Message-ID: <20130925045152.GD24243@verge.net.au> (raw)
In-Reply-To: <CACRpkdYMGiYzLisWfx_wQtw3Gvi3==0D5o7=BG3jcjH-0ea8gA@mail.gmail.com>
On Mon, Sep 23, 2013 at 10:50:07AM +0200, Linus Walleij wrote:
> On Tue, Sep 17, 2013 at 7:10 PM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
> > On Tue, 17 Sep 2013, Linus Walleij wrote:
>
> >> > +/* R8A7790 has 6 banks with 32 GPIOs in each = 192 GPIOs */
> >> > +#define ROW_GROUP_A(r) ('Z' - 'A' + 1 + (r))
> >> > +#define PIN_NUMBER(r, c) (((r) - 'A') * 16 + (c) + 200)
> >> > +#define PIN_A_NUMBER(r, c) PIN_NUMBER(ROW_GROUP_A(r), c)
> >>
> >> You add these #defines but do not use them.
> >
> > ehm, actually I do:
>
> Argh I was just wrong, forget about this.
>
> Woudl really like Laurent's ACK on this before I apply it though.
Laurent, ping.
next prev parent reply other threads:[~2013-09-25 4:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 16:03 [PATCH 0/4] ARM: shmobile: CPUFreq support on Lager Guennadi Liakhovetski
2013-09-09 16:03 ` [PATCH 1/4] pinctrl: sh-pfc: r8a7790: add pin definitions for the I2C3 interface Guennadi Liakhovetski
2013-09-17 12:20 ` Linus Walleij
2013-09-17 17:10 ` Guennadi Liakhovetski
2013-09-23 8:50 ` Linus Walleij
2013-09-25 4:51 ` Simon Horman [this message]
2013-09-25 8:46 ` Laurent Pinchart
2013-09-26 9:24 ` Guennadi Liakhovetski
2013-09-26 9:30 ` Laurent Pinchart
2013-09-09 16:03 ` [PATCH 2/4] ARM: shmobile: r8a7790: add I2C support in Device Tree mode Guennadi Liakhovetski
2013-09-25 8:52 ` Laurent Pinchart
2013-09-25 22:10 ` Guennadi Liakhovetski
2013-09-26 4:05 ` Magnus Damm
2013-09-26 7:07 ` Guennadi Liakhovetski
2013-09-26 9:32 ` Magnus Damm
2013-09-26 1:49 ` Simon Horman
2013-09-09 16:03 ` [PATCH 3/4] ARM: shmobile: r8a7790: add CPUFreq clock support Guennadi Liakhovetski
2013-09-25 4:58 ` Simon Horman
2013-09-09 16:03 ` [PATCH/RFC 4/4] ARM: shmobile: lager: add CPUFreq support Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130925045152.GD24243@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski+renesas@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).