linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling
@ 2013-07-10 19:21 Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling Guennadi Liakhovetski
                   ` (6 more replies)
  0 siblings, 7 replies; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

This patch series adds version-specific support for Command Completion 
Signal and the CE_CLK_CTRL2 register. Presumably, the first two patches 
will go via the MMC tree, the rest should be applied after them.

Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>

Guennadi Liakhovetski (6):
  mmc: sh_mmcif: revision-specific Command Completion Signal handling
  mmc: sh_mmcif: revision-specific CLK_CTRL2 handling
  ARM: shmobile: armadillo800eva: disable MMCIF Command Completion
    Signal
  ARM: shmobile: kzm9g: disable MMCIF Command Completion Signal
  ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal
  ARM: shmobile: lager: disable MMCIF Command Completion Signal, add
    CLK_CTRL2

 arch/arm/mach-shmobile/board-ape6evm.c         |    1 +
 arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
 arch/arm/mach-shmobile/board-kzm9g.c           |    1 +
 arch/arm/mach-shmobile/board-lager.c           |    2 +
 drivers/mmc/host/sh_mmcif.c                    |   31 +++++++++++++++++++----
 include/linux/mmc/sh_mmcif.h                   |    3 ++
 6 files changed, 33 insertions(+), 6 deletions(-)

-- 
1.7.2.5

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 13+ messages in thread

* [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 2/6] mmc: sh_mmcif: revision-specific CLK_CTRL2 handling Guennadi Liakhovetski
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

Some earlier MMCIF IP revisions contained Command Completion Signal
support, which has been dropped again in modern versions. Sopport for
this feature is added in a way to preserve the current behaviour by
default, i.e. when it is not enabled in platform data. Patch is based
on work by Nobuyuki HIRAI.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 drivers/mmc/host/sh_mmcif.c  |   27 +++++++++++++++++++++------
 include/linux/mmc/sh_mmcif.h |    1 +
 2 files changed, 22 insertions(+), 6 deletions(-)

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 06caaae..7be20c9 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -133,6 +133,8 @@
 				 INT_BUFWEN | INT_CMD12DRE | INT_BUFRE | \
 				 INT_DTRANE | INT_CMD12RBE | INT_CMD12CRE)
 
+#define INT_CCS			(INT_CCSTO | INT_CCSRCV | INT_CCSDE)
+
 /* CE_INT_MASK */
 #define MASK_ALL		0x00000000
 #define MASK_MCCSDE		(1 << 29)
@@ -161,7 +163,7 @@
 
 #define MASK_START_CMD		(MASK_MCMDVIO | MASK_MBUFVIO | MASK_MWDATERR | \
 				 MASK_MRDATERR | MASK_MRIDXERR | MASK_MRSPERR | \
-				 MASK_MCCSTO | MASK_MCRCSTO | MASK_MWDATTO | \
+				 MASK_MCRCSTO | MASK_MWDATTO | \
 				 MASK_MRDATTO | MASK_MRBSYTO | MASK_MRSPTO)
 
 #define MASK_CLEAN		(INT_ERR_STS | MASK_MRBSYE | MASK_MCRSPE |	\
@@ -243,6 +245,7 @@ struct sh_mmcif_host {
 	int sg_blkidx;
 	bool power;
 	bool card_present;
+	bool ccs_enable;		/* Command Completion Signal support */
 	struct mutex thread_lock;
 
 	/* DMA support */
@@ -485,8 +488,10 @@ static void sh_mmcif_sync_reset(struct sh_mmcif_host *host)
 
 	sh_mmcif_writel(host->addr, MMCIF_CE_VERSION, SOFT_RST_ON);
 	sh_mmcif_writel(host->addr, MMCIF_CE_VERSION, SOFT_RST_OFF);
+	if (host->ccs_enable)
+		tmp |= SCCSTO_29;
 	sh_mmcif_bitset(host, MMCIF_CE_CLK_CTRL, tmp |
-		SRSPTO_256 | SRBSYTO_29 | SRWDTO_29 | SCCSTO_29);
+		SRSPTO_256 | SRBSYTO_29 | SRWDTO_29);
 	/* byte swap on */
 	sh_mmcif_bitset(host, MMCIF_CE_BUF_ACC, BUF_ACC_ATYP);
 }
@@ -866,6 +871,9 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
 		break;
 	}
 
+	if (host->ccs_enable)
+		mask |= MASK_MCCSTO;
+
 	if (mrq->data) {
 		sh_mmcif_writel(host->addr, MMCIF_CE_BLOCK_SET, 0);
 		sh_mmcif_writel(host->addr, MMCIF_CE_BLOCK_SET,
@@ -873,7 +881,10 @@ static void sh_mmcif_start_cmd(struct sh_mmcif_host *host,
 	}
 	opc = sh_mmcif_set_cmd(host, mrq);
 
-	sh_mmcif_writel(host->addr, MMCIF_CE_INT, 0xD80430C0);
+	if (host->ccs_enable)
+		sh_mmcif_writel(host->addr, MMCIF_CE_INT, 0xD80430C0);
+	else
+		sh_mmcif_writel(host->addr, MMCIF_CE_INT, 0xD80430C0 | INT_CCS);
 	sh_mmcif_writel(host->addr, MMCIF_CE_INT_MASK, mask);
 	/* set arg */
 	sh_mmcif_writel(host->addr, MMCIF_CE_ARG, cmd->arg);
@@ -1241,11 +1252,14 @@ static irqreturn_t sh_mmcif_irqt(int irq, void *dev_id)
 static irqreturn_t sh_mmcif_intr(int irq, void *dev_id)
 {
 	struct sh_mmcif_host *host = dev_id;
-	u32 state;
+	u32 state, mask;
 
 	state = sh_mmcif_readl(host->addr, MMCIF_CE_INT);
-	sh_mmcif_writel(host->addr, MMCIF_CE_INT,
-			~(state & sh_mmcif_readl(host->addr, MMCIF_CE_INT_MASK)));
+	mask = sh_mmcif_readl(host->addr, MMCIF_CE_INT_MASK);
+	if (host->ccs_enable)
+		sh_mmcif_writel(host->addr, MMCIF_CE_INT, ~(state & mask));
+	else
+		sh_mmcif_writel(host->addr, MMCIF_CE_INT, INT_CCS | ~(state & mask));
 	sh_mmcif_bitclr(host, MMCIF_CE_INT_MASK, state & MASK_CLEAN);
 
 	if (state & ~MASK_CLEAN)
@@ -1375,6 +1389,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
 	host->mmc	= mmc;
 	host->addr	= reg;
 	host->timeout	= msecs_to_jiffies(1000);
+	host->ccs_enable = !pd || !pd->ccs_unsupported;
 
 	host->pd = pdev;
 
diff --git a/include/linux/mmc/sh_mmcif.h b/include/linux/mmc/sh_mmcif.h
index e7d5dd6..b2a22b6 100644
--- a/include/linux/mmc/sh_mmcif.h
+++ b/include/linux/mmc/sh_mmcif.h
@@ -39,6 +39,7 @@ struct sh_mmcif_plat_data {
 	unsigned int		slave_id_tx;	/* embedded slave_id_[tr]x */
 	unsigned int		slave_id_rx;
 	bool			use_cd_gpio : 1;
+	bool			ccs_unsupported : 1;
 	unsigned int		cd_gpio;
 	u8			sup_pclk;	/* 1 :SH7757, 0: SH7724/SH7372 */
 	unsigned long		caps;
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 2/6] mmc: sh_mmcif: revision-specific CLK_CTRL2 handling
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

Some newer MMCIF IP revisions contain a CE_CLK_CTRL2 register, that has to
be set for proper operation. Support for this feature is added in a way to
preserve the current behaviour by default, i.e. when it is not enabled
in platform data. Patch is based on work by Nobuyuki HIRAI.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 drivers/mmc/host/sh_mmcif.c  |    4 ++++
 include/linux/mmc/sh_mmcif.h |    2 ++
 2 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 7be20c9..dc3ce52 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -246,6 +246,7 @@ struct sh_mmcif_host {
 	bool power;
 	bool card_present;
 	bool ccs_enable;		/* Command Completion Signal support */
+	bool clk_ctrl2_enable;
 	struct mutex thread_lock;
 
 	/* DMA support */
@@ -490,6 +491,8 @@ static void sh_mmcif_sync_reset(struct sh_mmcif_host *host)
 	sh_mmcif_writel(host->addr, MMCIF_CE_VERSION, SOFT_RST_OFF);
 	if (host->ccs_enable)
 		tmp |= SCCSTO_29;
+	if (host->clk_ctrl2_enable)
+		sh_mmcif_writel(host->addr, MMCIF_CE_CLK_CTRL2, 0x0F0F0000);
 	sh_mmcif_bitset(host, MMCIF_CE_CLK_CTRL, tmp |
 		SRSPTO_256 | SRBSYTO_29 | SRWDTO_29);
 	/* byte swap on */
@@ -1390,6 +1393,7 @@ static int sh_mmcif_probe(struct platform_device *pdev)
 	host->addr	= reg;
 	host->timeout	= msecs_to_jiffies(1000);
 	host->ccs_enable = !pd || !pd->ccs_unsupported;
+	host->clk_ctrl2_enable = pd && pd->clk_ctrl2_present;
 
 	host->pd = pdev;
 
diff --git a/include/linux/mmc/sh_mmcif.h b/include/linux/mmc/sh_mmcif.h
index b2a22b6..d4277d9 100644
--- a/include/linux/mmc/sh_mmcif.h
+++ b/include/linux/mmc/sh_mmcif.h
@@ -40,6 +40,7 @@ struct sh_mmcif_plat_data {
 	unsigned int		slave_id_rx;
 	bool			use_cd_gpio : 1;
 	bool			ccs_unsupported : 1;
+	bool			clk_ctrl2_present : 1;
 	unsigned int		cd_gpio;
 	u8			sup_pclk;	/* 1 :SH7757, 0: SH7724/SH7372 */
 	unsigned long		caps;
@@ -63,6 +64,7 @@ struct sh_mmcif_plat_data {
 #define MMCIF_CE_INT_MASK	0x00000044
 #define MMCIF_CE_HOST_STS1	0x00000048
 #define MMCIF_CE_HOST_STS2	0x0000004C
+#define MMCIF_CE_CLK_CTRL2	0x00000070
 #define MMCIF_CE_VERSION	0x0000007C
 
 /* CE_BUF_ACC */
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling Guennadi Liakhovetski
  2013-07-10 19:21 ` [PATCH 2/6] mmc: sh_mmcif: revision-specific CLK_CTRL2 handling Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-09-25  7:12   ` Simon Horman
  2013-09-25  7:12   ` Simon Horman
  2013-07-10 19:21 ` [PATCH 4/6] ARM: shmobile: kzm9g: " Guennadi Liakhovetski
                   ` (3 subsequent siblings)
  6 siblings, 2 replies; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

MMCIF on r8a7740 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on armadillo800eva.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
index 41ff7d65..3cb006b 100644
--- a/arch/arm/mach-shmobile/board-armadillo800eva.c
+++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
@@ -778,6 +778,7 @@ static struct sh_mmcif_plat_data sh_mmcif_plat = {
 	.caps		= MMC_CAP_4_BIT_DATA |
 			  MMC_CAP_8_BIT_DATA |
 			  MMC_CAP_NONREMOVABLE,
+	.ccs_unsupported = true,
 	.slave_id_tx	= SHDMA_SLAVE_MMCIF_TX,
 	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
 };
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 4/6] ARM: shmobile: kzm9g: disable MMCIF Command Completion Signal
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
                   ` (2 preceding siblings ...)
  2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-09-25  7:12   ` Simon Horman
  2013-07-10 19:21 ` [PATCH 5/6] ARM: shmobile: ape6evm: " Guennadi Liakhovetski
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

MMCIF on sh73a0 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on kzm9g.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-kzm9g.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index 165483c..7ec26a5 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
@@ -365,6 +365,7 @@ static struct resource sh_mmcif_resources[] = {
 static struct sh_mmcif_plat_data sh_mmcif_platdata = {
 	.ocr		= MMC_VDD_165_195,
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.ccs_unsupported = true,
 	.slave_id_tx	= SHDMA_SLAVE_MMCIF_TX,
 	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
 };
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 5/6] ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
                   ` (3 preceding siblings ...)
  2013-07-10 19:21 ` [PATCH 4/6] ARM: shmobile: kzm9g: " Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-09-25  7:12   ` Simon Horman
  2013-07-10 19:21 ` [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2 Guennadi Liakhovetski
  2013-08-25  4:12 ` [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Chris Ball
  6 siblings, 1 reply; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on ape6evm.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-ape6evm.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index e9e2108e..96a6994 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -77,6 +77,7 @@ static struct sh_mmcif_plat_data mmcif0_pdata = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
 	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
 	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
+	.ccs_unsupported = true,
 };
 
 static struct resource mmcif0_resources[] = {
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
                   ` (4 preceding siblings ...)
  2013-07-10 19:21 ` [PATCH 5/6] ARM: shmobile: ape6evm: " Guennadi Liakhovetski
@ 2013-07-10 19:21 ` Guennadi Liakhovetski
  2013-09-25  7:12   ` Simon Horman
  2013-08-25  4:12 ` [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Chris Ball
  6 siblings, 1 reply; 13+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-10 19:21 UTC (permalink / raw)
  To: linux-mmc
  Cc: linux-sh, Magnus Damm, Simon Horman, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

MMCIF on r8a7790 doesn't support Command Completion Signal, but it does
implement a CE_CLK_CTRL2 register. Platform parameters have to be added to
account for these features on lager.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-lager.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-lager.c b/arch/arm/mach-shmobile/board-lager.c
index 3c67b2a..9b3085f 100644
--- a/arch/arm/mach-shmobile/board-lager.c
+++ b/arch/arm/mach-shmobile/board-lager.c
@@ -84,6 +84,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[]  /* MMCIF */
 static struct sh_mmcif_plat_data mmcif1_pdata = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.clk_ctrl2_present = true,
+	.ccs_unsupported = true,
 };
 
 static struct resource mmcif1_resources[] = {
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling
  2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
                   ` (5 preceding siblings ...)
  2013-07-10 19:21 ` [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2 Guennadi Liakhovetski
@ 2013-08-25  4:12 ` Chris Ball
  6 siblings, 0 replies; 13+ messages in thread
From: Chris Ball @ 2013-08-25  4:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Simon Horman, Nobuyuki HIRAI,
	Guennadi Liakhovetski

Hi Guennadi,

On Wed, Jul 10 2013, Guennadi Liakhovetski wrote:
> This patch series adds version-specific support for Command Completion 
> Signal and the CE_CLK_CTRL2 register. Presumably, the first two patches 
> will go via the MMC tree, the rest should be applied after them.
>
> Cc: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
>
> Guennadi Liakhovetski (6):
>   mmc: sh_mmcif: revision-specific Command Completion Signal handling
>   mmc: sh_mmcif: revision-specific CLK_CTRL2 handling

Thanks, I've pushed these two patches to mmc-next for 3.12.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal
  2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
@ 2013-09-25  7:12   ` Simon Horman
  2013-09-25  7:12   ` Simon Horman
  1 sibling, 0 replies; 13+ messages in thread
From: Simon Horman @ 2013-09-25  7:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

On Wed, Jul 10, 2013 at 09:21:14PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a7740 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on armadillo800eva.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>

Thanks, I have queued this up for v3.13.

> ---
>  arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index 41ff7d65..3cb006b 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -778,6 +778,7 @@ static struct sh_mmcif_plat_data sh_mmcif_plat = {
>  	.caps		= MMC_CAP_4_BIT_DATA |
>  			  MMC_CAP_8_BIT_DATA |
>  			  MMC_CAP_NONREMOVABLE,
> +	.ccs_unsupported = true,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
>  };
> -- 
> 1.7.2.5
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal
  2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
  2013-09-25  7:12   ` Simon Horman
@ 2013-09-25  7:12   ` Simon Horman
  1 sibling, 0 replies; 13+ messages in thread
From: Simon Horman @ 2013-09-25  7:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

On Wed, Jul 10, 2013 at 09:21:14PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a7740 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on armadillo800eva.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-armadillo800eva.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> index 41ff7d65..3cb006b 100644
> --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> @@ -778,6 +778,7 @@ static struct sh_mmcif_plat_data sh_mmcif_plat = {
>  	.caps		= MMC_CAP_4_BIT_DATA |
>  			  MMC_CAP_8_BIT_DATA |
>  			  MMC_CAP_NONREMOVABLE,
> +	.ccs_unsupported = true,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
>  };

Thanks, I have queued this up for v3.13.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 4/6] ARM: shmobile: kzm9g: disable MMCIF Command Completion Signal
  2013-07-10 19:21 ` [PATCH 4/6] ARM: shmobile: kzm9g: " Guennadi Liakhovetski
@ 2013-09-25  7:12   ` Simon Horman
  0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2013-09-25  7:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

On Wed, Jul 10, 2013 at 09:21:15PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on sh73a0 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on kzm9g.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-kzm9g.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
> index 165483c..7ec26a5 100644
> --- a/arch/arm/mach-shmobile/board-kzm9g.c
> +++ b/arch/arm/mach-shmobile/board-kzm9g.c
> @@ -365,6 +365,7 @@ static struct resource sh_mmcif_resources[] = {
>  static struct sh_mmcif_plat_data sh_mmcif_platdata = {
>  	.ocr		= MMC_VDD_165_195,
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +	.ccs_unsupported = true,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
>  };
> -- 
> 1.7.2.5

Thanks, I have queued this up for v3.13.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH 5/6] ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal
  2013-07-10 19:21 ` [PATCH 5/6] ARM: shmobile: ape6evm: " Guennadi Liakhovetski
@ 2013-09-25  7:12   ` Simon Horman
  0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2013-09-25  7:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

On Wed, Jul 10, 2013 at 09:21:16PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
> parameter has to be added to disable it on ape6evm.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-ape6evm.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index e9e2108e..96a6994 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> @@ -77,6 +77,7 @@ static struct sh_mmcif_plat_data mmcif0_pdata = {
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
>  	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> +	.ccs_unsupported = true,
>  };
>  
>  static struct resource mmcif0_resources[] = {

Thanks, I have queued up the following for v3.13.


From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

ARM: shmobile: ape6evm: disable MMCIF Command Completion Signal

MMCIF on r8a73a4 doesn't support Command Completion Signal, a platform
parameter has to be added to disable it on ape6evm.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm/mach-shmobile/board-ape6evm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index 02be420..0365d2e 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -162,6 +162,7 @@ static struct regulator_consumer_supply vcc_sdhi1_consumers[]  /* MMCIF */
 static const struct sh_mmcif_plat_data mmcif0_pdata __initconst = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.ccs_unsupported = true,
 };
 
 static const struct resource mmcif0_resources[] __initconst = {
-- 
1.8.4


^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2
  2013-07-10 19:21 ` [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2 Guennadi Liakhovetski
@ 2013-09-25  7:12   ` Simon Horman
  0 siblings, 0 replies; 13+ messages in thread
From: Simon Horman @ 2013-09-25  7:12 UTC (permalink / raw)
  To: Guennadi Liakhovetski
  Cc: linux-mmc, linux-sh, Magnus Damm, Chris Ball, Nobuyuki HIRAI,
	Guennadi Liakhovetski

On Wed, Jul 10, 2013 at 09:21:17PM +0200, Guennadi Liakhovetski wrote:
> MMCIF on r8a7790 doesn't support Command Completion Signal, but it does
> implement a CE_CLK_CTRL2 register. Platform parameters have to be added to
> account for these features on lager.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>

Thanks, I have queued this up for v3.13.

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2013-09-25  7:12 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-10 19:21 [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 1/6] mmc: sh_mmcif: revision-specific Command Completion Signal handling Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 2/6] mmc: sh_mmcif: revision-specific CLK_CTRL2 handling Guennadi Liakhovetski
2013-07-10 19:21 ` [PATCH 3/6] ARM: shmobile: armadillo800eva: disable MMCIF Command Completion Signal Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-09-25  7:12   ` Simon Horman
2013-07-10 19:21 ` [PATCH 4/6] ARM: shmobile: kzm9g: " Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-07-10 19:21 ` [PATCH 5/6] ARM: shmobile: ape6evm: " Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-07-10 19:21 ` [PATCH 6/6] ARM: shmobile: lager: disable MMCIF Command Completion Signal, add CLK_CTRL2 Guennadi Liakhovetski
2013-09-25  7:12   ` Simon Horman
2013-08-25  4:12 ` [PATCH 0/6] mmc: sh_mmcif: revision-specific CCS and CLK_CTRL2 handling Chris Ball

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).