linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
@ 2013-07-22 13:16 Guennadi Liakhovetski
  2013-09-25  6:09 ` Simon Horman
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2013-07-22 13:16 UTC (permalink / raw)
  To: linux-sh

Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
---
 arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
index 97c0dad..96a6994 100644
--- a/arch/arm/mach-shmobile/board-ape6evm.c
+++ b/arch/arm/mach-shmobile/board-ape6evm.c
@@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[]  /* MMCIF */
 static struct sh_mmcif_plat_data mmcif0_pdata = {
 	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
+	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
+	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
 	.ccs_unsupported = true,
 };
 
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
  2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
@ 2013-09-25  6:09 ` Simon Horman
  2013-09-25  7:03 ` Guennadi Liakhovetski
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-09-25  6:09 UTC (permalink / raw)
  To: linux-sh

On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> ---
>  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> index 97c0dad..96a6994 100644
> --- a/arch/arm/mach-shmobile/board-ape6evm.c
> +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] >  /* MMCIF */
>  static struct sh_mmcif_plat_data mmcif0_pdata = {
>  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
>  	.ccs_unsupported = true,
>  };

Thanks, I have queued this up for v3.13.
Please let me know if any other patches in this series are relevant for v3.13.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
  2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
  2013-09-25  6:09 ` Simon Horman
@ 2013-09-25  7:03 ` Guennadi Liakhovetski
  2013-09-25  7:20 ` Simon Horman
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2013-09-25  7:03 UTC (permalink / raw)
  To: linux-sh

Hi Simon

On Wed, 25 Sep 2013, Simon Horman wrote:

> On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > ---
> >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > index 97c0dad..96a6994 100644
> > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] > >  /* MMCIF */
> >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> >  	.ccs_unsupported = true,
> >  };
> 
> Thanks, I have queued this up for v3.13.
> Please let me know if any other patches in this series are relevant for v3.13.

I don't think so, no. Other patches in this series (apart from 2, which 
you already included from the earlier one today) require DMA DT support 
for other SoCs, which we dropped for the time being.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
  2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
  2013-09-25  6:09 ` Simon Horman
  2013-09-25  7:03 ` Guennadi Liakhovetski
@ 2013-09-25  7:20 ` Simon Horman
  2013-09-25  7:32 ` Guennadi Liakhovetski
  2013-09-25  7:55 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-09-25  7:20 UTC (permalink / raw)
  To: linux-sh

On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 25 Sep 2013, Simon Horman wrote:
> 
> > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > 
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > ---
> > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > index 97c0dad..96a6994 100644
> > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] > > >  /* MMCIF */
> > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > >  	.ccs_unsupported = true,
> > >  };
> > 
> > Thanks, I have queued this up for v3.13.
> > Please let me know if any other patches in this series are relevant for v3.13.
> 
> I don't think so, no. Other patches in this series (apart from 2, which 
> you already included from the earlier one today) require DMA DT support 
> for other SoCs, which we dropped for the time being.

I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
anywhere in the renesas tree. Perhaps I need a dependency?

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
  2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
                   ` (2 preceding siblings ...)
  2013-09-25  7:20 ` Simon Horman
@ 2013-09-25  7:32 ` Guennadi Liakhovetski
  2013-09-25  7:55 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2013-09-25  7:32 UTC (permalink / raw)
  To: linux-sh

Hi Simon

On Wed, 25 Sep 2013, Simon Horman wrote:

> On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> > Hi Simon
> > 
> > On Wed, 25 Sep 2013, Simon Horman wrote:
> > 
> > > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > > 
> > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > > ---
> > > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > 
> > > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > index 97c0dad..96a6994 100644
> > > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] > > > >  /* MMCIF */
> > > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > > >  	.ccs_unsupported = true,
> > > >  };
> > > 
> > > Thanks, I have queued this up for v3.13.
> > > Please let me know if any other patches in this series are relevant for v3.13.
> > 
> > I don't think so, no. Other patches in this series (apart from 2, which 
> > you already included from the earlier one today) require DMA DT support 
> > for other SoCs, which we dropped for the time being.
> 
> I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
> anywhere in the renesas tree. Perhaps I need a dependency?

They are added in

[PATCH v5 5/7] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it

which you also presumably just applied.

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF
  2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
                   ` (3 preceding siblings ...)
  2013-09-25  7:32 ` Guennadi Liakhovetski
@ 2013-09-25  7:55 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2013-09-25  7:55 UTC (permalink / raw)
  To: linux-sh

On Wed, Sep 25, 2013 at 09:32:38AM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
> 
> On Wed, 25 Sep 2013, Simon Horman wrote:
> 
> > On Wed, Sep 25, 2013 at 09:03:29AM +0200, Guennadi Liakhovetski wrote:
> > > Hi Simon
> > > 
> > > On Wed, 25 Sep 2013, Simon Horman wrote:
> > > 
> > > > On Mon, Jul 22, 2013 at 03:16:16PM +0200, Guennadi Liakhovetski wrote:
> > > > > Add DMA support for MMCIF on APE6EVM, using the shdma dmaengine driver.
> > > > > 
> > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski+renesas@gmail.com>
> > > > > ---
> > > > >  arch/arm/mach-shmobile/board-ape6evm.c |    2 ++
> > > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > > > 
> > > > > diff --git a/arch/arm/mach-shmobile/board-ape6evm.c b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > index 97c0dad..96a6994 100644
> > > > > --- a/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > +++ b/arch/arm/mach-shmobile/board-ape6evm.c
> > > > > @@ -75,6 +75,8 @@ static struct regulator_consumer_supply fixed3v3_power_consumers[] > > > > >  /* MMCIF */
> > > > >  static struct sh_mmcif_plat_data mmcif0_pdata = {
> > > > >  	.caps		= MMC_CAP_8_BIT_DATA | MMC_CAP_NONREMOVABLE,
> > > > > +	.slave_id_tx	= SHDMA_SLAVE_MMCIF0_TX,
> > > > > +	.slave_id_rx	= SHDMA_SLAVE_MMCIF0_RX,
> > > > >  	.ccs_unsupported = true,
> > > > >  };
> > > > 
> > > > Thanks, I have queued this up for v3.13.
> > > > Please let me know if any other patches in this series are relevant for v3.13.
> > > 
> > > I don't think so, no. Other patches in this series (apart from 2, which 
> > > you already included from the earlier one today) require DMA DT support 
> > > for other SoCs, which we dropped for the time being.
> > 
> > I have dropped this patch as I don't see SHDMA_SLAVE_MMCIF0_TX
> > anywhere in the renesas tree. Perhaps I need a dependency?
> 
> They are added in
> 
> [PATCH v5 5/7] ARM: shmobile: r8a73a4: add a DMAC platform device and clock for it
> 
> which you also presumably just applied.

Thanks, silly me. I will re-queue this up.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-09-25  7:55 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-22 13:16 [PATCH 1/6] ARM: shmobile: ape6evm: add DMA support to MMCIF Guennadi Liakhovetski
2013-09-25  6:09 ` Simon Horman
2013-09-25  7:03 ` Guennadi Liakhovetski
2013-09-25  7:20 ` Simon Horman
2013-09-25  7:32 ` Guennadi Liakhovetski
2013-09-25  7:55 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).