From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 0/3] Add USBHS support to Lager (take 2)
Date: Wed, 09 Oct 2013 03:47:37 +0000 [thread overview]
Message-ID: <20131009034735.GP15065@verge.net.au> (raw)
In-Reply-To: <1381261407-12606-1-git-send-email-valentine.barshak@cogentembedded.com>
On Tue, Oct 08, 2013 at 07:09:36PM -0700, Kuninori Morimoto wrote:
>
> Hi
>
> > This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
> > also enables USBHS for the Lager board. It has been updated, based
> > on the comments to the previous version.
> >
> > The patches apply fine to the renesas-devel-20131008 tag of the renesas.git.
> > The first patch also applies fine to the usb.git at kernel.org.
> > It adds RCAR Gen2 phy driver which is used to configure the shared USB
> > channels 0/2 and to control USBHS internal PHY.
> > All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
> > should acquire the USB phy first to set proper channel configuration.
> >
> > The other two patches add USBHS support to Lager board, which requires
> > RCAR Gen2 phy driver.
> >
> > Changes from previous version:
> > * use-counting and clock handling done in the usb_phy_init/shutdown
> > callbacks only;
> > * a minor typo in the comments fixed;
> > * phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
> > * usb_phy_init/shutdown called from usbhs_power_ctrl callback
> > to allow renesas_usbhs driver disable USB PHY completely
> > when it is not needed.
> >
> > Valentine Barshak (3):
> > usb: phy: Add RCAR Gen2 USB phy
> > arm: shmobile: r8a7790: Add USBHS clock support
> > arm: shmobile: lager: Add USBHS support
> >
> > arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
> > arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
> > drivers/usb/phy/Kconfig | 13 ++
> > drivers/usb/phy/Makefile | 1 +
> > drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
> > include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
> > 6 files changed, 401 insertions(+)
> > create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
> > create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
>
> For all patches
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> # I think we can implement usb_phy_xxx() method
> # in renesas_usbhs driver someday.
Hi Felipe,
could you consider taking the first patch of this series?
And if so, could you provide a branch that I can use
as a base for the other changes in the series?
Thanks
next prev parent reply other threads:[~2013-10-09 3:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
2013-10-09 1:57 ` Simon Horman
2013-10-09 2:09 ` Kuninori Morimoto
2013-10-09 3:47 ` Simon Horman [this message]
2013-10-09 22:14 ` [PATCH 0/3] Add USBHS support to Lager (take 3) Valentine Barshak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131009034735.GP15065@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).