* [PATCH 0/3] Add USBHS support to Lager (take 2)
@ 2013-10-08 19:43 Valentine Barshak
2013-10-09 1:57 ` Simon Horman
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Valentine Barshak @ 2013-10-08 19:43 UTC (permalink / raw)
To: linux-sh
This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
also enables USBHS for the Lager board. It has been updated, based
on the comments to the previous version.
The patches apply fine to the renesas-devel-20131008 tag of the renesas.git.
The first patch also applies fine to the usb.git at kernel.org.
It adds RCAR Gen2 phy driver which is used to configure the shared USB
channels 0/2 and to control USBHS internal PHY.
All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
should acquire the USB phy first to set proper channel configuration.
The other two patches add USBHS support to Lager board, which requires
RCAR Gen2 phy driver.
Changes from previous version:
* use-counting and clock handling done in the usb_phy_init/shutdown
callbacks only;
* a minor typo in the comments fixed;
* phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
* usb_phy_init/shutdown called from usbhs_power_ctrl callback
to allow renesas_usbhs driver disable USB PHY completely
when it is not needed.
Valentine Barshak (3):
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: r8a7790: Add USBHS clock support
arm: shmobile: lager: Add USBHS support
arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy/Makefile | 1 +
drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
6 files changed, 401 insertions(+)
create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] Add USBHS support to Lager (take 2)
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
@ 2013-10-09 1:57 ` Simon Horman
2013-10-09 2:09 ` Kuninori Morimoto
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-10-09 1:57 UTC (permalink / raw)
To: linux-sh
On Tue, Oct 08, 2013 at 11:43:24PM +0400, Valentine Barshak wrote:
> This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
> also enables USBHS for the Lager board. It has been updated, based
> on the comments to the previous version.
>
> The patches apply fine to the renesas-devel-20131008 tag of the renesas.git.
> The first patch also applies fine to the usb.git at kernel.org.
> It adds RCAR Gen2 phy driver which is used to configure the shared USB
> channels 0/2 and to control USBHS internal PHY.
> All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
> should acquire the USB phy first to set proper channel configuration.
>
> The other two patches add USBHS support to Lager board, which requires
> RCAR Gen2 phy driver.
>
> Changes from previous version:
> * use-counting and clock handling done in the usb_phy_init/shutdown
> callbacks only;
> * a minor typo in the comments fixed;
> * phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
> * usb_phy_init/shutdown called from usbhs_power_ctrl callback
> to allow renesas_usbhs driver disable USB PHY completely
> when it is not needed.
Hi Morimoto-san,
I could you review this revised series?
My assumption is that in the current form the first patch will
go through the USB tree while the latter patches will subsequently
go through (my) renesas tree.
> Valentine Barshak (3):
> usb: phy: Add RCAR Gen2 USB phy
> arm: shmobile: r8a7790: Add USBHS clock support
> arm: shmobile: lager: Add USBHS support
>
> arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
> arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
> drivers/usb/phy/Kconfig | 13 ++
> drivers/usb/phy/Makefile | 1 +
> drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
> include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
> 6 files changed, 401 insertions(+)
> create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
> create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] Add USBHS support to Lager (take 2)
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
2013-10-09 1:57 ` Simon Horman
@ 2013-10-09 2:09 ` Kuninori Morimoto
2013-10-09 3:47 ` Simon Horman
2013-10-09 22:14 ` [PATCH 0/3] Add USBHS support to Lager (take 3) Valentine Barshak
3 siblings, 0 replies; 5+ messages in thread
From: Kuninori Morimoto @ 2013-10-09 2:09 UTC (permalink / raw)
To: linux-sh
Hi
> This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
> also enables USBHS for the Lager board. It has been updated, based
> on the comments to the previous version.
>
> The patches apply fine to the renesas-devel-20131008 tag of the renesas.git.
> The first patch also applies fine to the usb.git at kernel.org.
> It adds RCAR Gen2 phy driver which is used to configure the shared USB
> channels 0/2 and to control USBHS internal PHY.
> All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
> should acquire the USB phy first to set proper channel configuration.
>
> The other two patches add USBHS support to Lager board, which requires
> RCAR Gen2 phy driver.
>
> Changes from previous version:
> * use-counting and clock handling done in the usb_phy_init/shutdown
> callbacks only;
> * a minor typo in the comments fixed;
> * phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
> * usb_phy_init/shutdown called from usbhs_power_ctrl callback
> to allow renesas_usbhs driver disable USB PHY completely
> when it is not needed.
>
> Valentine Barshak (3):
> usb: phy: Add RCAR Gen2 USB phy
> arm: shmobile: r8a7790: Add USBHS clock support
> arm: shmobile: lager: Add USBHS support
>
> arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
> arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
> drivers/usb/phy/Kconfig | 13 ++
> drivers/usb/phy/Makefile | 1 +
> drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
> include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
> 6 files changed, 401 insertions(+)
> create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
> create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
For all patches
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
# I think we can implement usb_phy_xxx() method
# in renesas_usbhs driver someday.
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/3] Add USBHS support to Lager (take 2)
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
2013-10-09 1:57 ` Simon Horman
2013-10-09 2:09 ` Kuninori Morimoto
@ 2013-10-09 3:47 ` Simon Horman
2013-10-09 22:14 ` [PATCH 0/3] Add USBHS support to Lager (take 3) Valentine Barshak
3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2013-10-09 3:47 UTC (permalink / raw)
To: linux-sh
On Tue, Oct 08, 2013 at 07:09:36PM -0700, Kuninori Morimoto wrote:
>
> Hi
>
> > This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
> > also enables USBHS for the Lager board. It has been updated, based
> > on the comments to the previous version.
> >
> > The patches apply fine to the renesas-devel-20131008 tag of the renesas.git.
> > The first patch also applies fine to the usb.git at kernel.org.
> > It adds RCAR Gen2 phy driver which is used to configure the shared USB
> > channels 0/2 and to control USBHS internal PHY.
> > All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
> > should acquire the USB phy first to set proper channel configuration.
> >
> > The other two patches add USBHS support to Lager board, which requires
> > RCAR Gen2 phy driver.
> >
> > Changes from previous version:
> > * use-counting and clock handling done in the usb_phy_init/shutdown
> > callbacks only;
> > * a minor typo in the comments fixed;
> > * phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
> > * usb_phy_init/shutdown called from usbhs_power_ctrl callback
> > to allow renesas_usbhs driver disable USB PHY completely
> > when it is not needed.
> >
> > Valentine Barshak (3):
> > usb: phy: Add RCAR Gen2 USB phy
> > arm: shmobile: r8a7790: Add USBHS clock support
> > arm: shmobile: lager: Add USBHS support
> >
> > arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
> > arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
> > drivers/usb/phy/Kconfig | 13 ++
> > drivers/usb/phy/Makefile | 1 +
> > drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
> > include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
> > 6 files changed, 401 insertions(+)
> > create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
> > create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
>
> For all patches
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> # I think we can implement usb_phy_xxx() method
> # in renesas_usbhs driver someday.
Hi Felipe,
could you consider taking the first patch of this series?
And if so, could you provide a branch that I can use
as a base for the other changes in the series?
Thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/3] Add USBHS support to Lager (take 3)
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
` (2 preceding siblings ...)
2013-10-09 3:47 ` Simon Horman
@ 2013-10-09 22:14 ` Valentine Barshak
3 siblings, 0 replies; 5+ messages in thread
From: Valentine Barshak @ 2013-10-09 22:14 UTC (permalink / raw)
To: linux-sh
This patch set adds internal USB PHY support to RCAR Gen2 SoC, and
also enables USBHS for the Lager board. It has been updated, based
on the comments to the previous version.
The patches apply fine to the renesas-devel-20131009v2 tag of the renesas.git.
The first patch also applies fine to the usb.git at kernel.org.
It adds RCAR Gen2 phy driver which is used to configure the shared USB
channels 0/2 and to control USBHS internal PHY.
All the drivers that use the shared USB channels (USBHS/USBSS/PCI USB host)
should acquire the USB phy first to set proper channel configuration.
The other two patches add USBHS support to Lager board, which requires
RCAR Gen2 phy driver.
Changes from version 2:
* added COMPILE_TEST support to phy-rcar-gen2-usb;
* sorted phy-rcar-gen2-usb.c includes in the alphabetical order;
* dropped unnecessary checks and error messages
in the phy-rcar-gen2 probe callback.
Changes from version 1:
* use-counting and clock handling done in the usb_phy_init/shutdown
callbacks only;
* a minor typo in the comments fixed;
* phy clean up moved to __rcar_gen2_usb_phy_shutdown function;
* usb_phy_init/shutdown called from usbhs_power_ctrl callback
to allow renesas_usbhs driver disable USB PHY completely
when it is not needed.
Valentine Barshak (3):
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: r8a7790: Add USBHS clock support
arm: shmobile: lager: Add USBHS support
arch/arm/mach-shmobile/board-lager.c | 106 ++++++++++
arch/arm/mach-shmobile/clock-r8a7790.c | 4 +
drivers/usb/phy/Kconfig | 13 ++
drivers/usb/phy/Makefile | 1 +
drivers/usb/phy/phy-rcar-gen2-usb.c | 255 ++++++++++++++++++++++++
include/linux/platform_data/usb-rcar-gen2-phy.h | 22 ++
6 files changed, 401 insertions(+)
create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
--
1.8.3.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-09 22:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-08 19:43 [PATCH 0/3] Add USBHS support to Lager (take 2) Valentine Barshak
2013-10-09 1:57 ` Simon Horman
2013-10-09 2:09 ` Kuninori Morimoto
2013-10-09 3:47 ` Simon Horman
2013-10-09 22:14 ` [PATCH 0/3] Add USBHS support to Lager (take 3) Valentine Barshak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).