From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
Date: Wed, 16 Oct 2013 06:09:04 +0000 [thread overview]
Message-ID: <20131016060902.GC15425@verge.net.au> (raw)
In-Reply-To: <87d2nc1fi8.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Oct 14, 2013 at 06:07:31PM -0700, Kuninori Morimoto wrote:
> Hi Simon again
>
> > > > "The name of a node should be somewhat generic, reflecting the
> > > > function of the device and not its precise programming model." So I
> > > > suggest using "mmc" or "sd" instead.
> > > >
> > > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> > >
> > > Morimoto-san,
> > >
> > > would it be possible for you to either update this patch or provide a
> > > subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> > > slight preference for "mmc" but please use your own judgement.
> > >
> > > If you could also provide patches to update existing dts/dtsi files
> > > that would be awesome.
> >
> > I see.
> > But, we already have both SDHI and MMCIF now.
> > I guess below naming seems good.
> >
> > - SDHI -> sd
> > - MMCIF -> mmc
> >
> > what do you think ?
Sounds good.
> And, I will send fixup patches for existing dts/dtsi.
> Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> or do you want to me v2 patches for these ?
I'm happy to take your current patches as-is and then apply
naming fixes on top.
next prev parent reply other threads:[~2013-10-16 6:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
2013-10-11 20:27 ` Sergei Shtylyov
2013-10-15 0:35 ` Simon Horman
2013-10-15 0:47 ` Kuninori Morimoto
2013-10-15 1:07 ` Kuninori Morimoto
2013-10-16 6:09 ` Simon Horman [this message]
2013-10-17 2:51 ` Kuninori Morimoto
2013-10-17 4:23 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016060902.GC15425@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).