* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
@ 2013-10-11 20:27 ` Sergei Shtylyov
2013-10-15 0:35 ` Simon Horman
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2013-10-11 20:27 UTC (permalink / raw)
To: linux-sh
Hello.
On 11-10-2013 8:35, Kuninori Morimoto wrote:
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> arch/arm/boot/dts/r8a7778.dtsi | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
> diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> index 0ff38e6..873eeb9 100644
> --- a/arch/arm/boot/dts/r8a7778.dtsi
> +++ b/arch/arm/boot/dts/r8a7778.dtsi
> @@ -164,4 +164,34 @@
> interrupts = <0 61 4>;
> status = "disabled";
> };
> +
> + sdhi0: sdhi@ffe4c000 {
ePAPR spec [1] says:
"The name of a node should be somewhat generic, reflecting the function of the
device and not its precise programming model." So I suggest using "mmc" or
"sd" instead.
[1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
WBR, Sergei
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
2013-10-11 20:27 ` Sergei Shtylyov
@ 2013-10-15 0:35 ` Simon Horman
2013-10-15 0:47 ` Kuninori Morimoto
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-10-15 0:35 UTC (permalink / raw)
To: linux-sh
On Fri, Oct 11, 2013 at 11:26:33PM +0200, Sergei Shtylyov wrote:
> Hello.
>
> On 11-10-2013 8:35, Kuninori Morimoto wrote:
>
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> > arch/arm/boot/dts/r8a7778.dtsi | 30 ++++++++++++++++++++++++++++++
> > 1 file changed, 30 insertions(+)
>
> >diff --git a/arch/arm/boot/dts/r8a7778.dtsi b/arch/arm/boot/dts/r8a7778.dtsi
> >index 0ff38e6..873eeb9 100644
> >--- a/arch/arm/boot/dts/r8a7778.dtsi
> >+++ b/arch/arm/boot/dts/r8a7778.dtsi
> >@@ -164,4 +164,34 @@
> > interrupts = <0 61 4>;
> > status = "disabled";
> > };
> >+
> >+ sdhi0: sdhi@ffe4c000 {
>
> ePAPR spec [1] says:
>
> "The name of a node should be somewhat generic, reflecting the
> function of the device and not its precise programming model." So I
> suggest using "mmc" or "sd" instead.
>
> [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
Morimoto-san,
would it be possible for you to either update this patch or provide a
subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
slight preference for "mmc" but please use your own judgement.
If you could also provide patches to update existing dts/dtsi files
that would be awesome.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
2013-10-11 20:27 ` Sergei Shtylyov
2013-10-15 0:35 ` Simon Horman
@ 2013-10-15 0:47 ` Kuninori Morimoto
2013-10-15 1:07 ` Kuninori Morimoto
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2013-10-15 0:47 UTC (permalink / raw)
To: linux-sh
Hi Magnus, Simon
> > "The name of a node should be somewhat generic, reflecting the
> > function of the device and not its precise programming model." So I
> > suggest using "mmc" or "sd" instead.
> >
> > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
>
> Morimoto-san,
>
> would it be possible for you to either update this patch or provide a
> subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> slight preference for "mmc" but please use your own judgement.
>
> If you could also provide patches to update existing dts/dtsi files
> that would be awesome.
I see.
But, we already have both SDHI and MMCIF now.
I guess below naming seems good.
- SDHI -> sd
- MMCIF -> mmc
what do you think ?
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
` (2 preceding siblings ...)
2013-10-15 0:47 ` Kuninori Morimoto
@ 2013-10-15 1:07 ` Kuninori Morimoto
2013-10-16 6:09 ` Simon Horman
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2013-10-15 1:07 UTC (permalink / raw)
To: linux-sh
Hi Simon again
> > > "The name of a node should be somewhat generic, reflecting the
> > > function of the device and not its precise programming model." So I
> > > suggest using "mmc" or "sd" instead.
> > >
> > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> >
> > Morimoto-san,
> >
> > would it be possible for you to either update this patch or provide a
> > subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> > slight preference for "mmc" but please use your own judgement.
> >
> > If you could also provide patches to update existing dts/dtsi files
> > that would be awesome.
>
> I see.
> But, we already have both SDHI and MMCIF now.
> I guess below naming seems good.
>
> - SDHI -> sd
> - MMCIF -> mmc
>
> what do you think ?
And, I will send fixup patches for existing dts/dtsi.
Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
or do you want to me v2 patches for these ?
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
` (3 preceding siblings ...)
2013-10-15 1:07 ` Kuninori Morimoto
@ 2013-10-16 6:09 ` Simon Horman
2013-10-17 2:51 ` Kuninori Morimoto
2013-10-17 4:23 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-10-16 6:09 UTC (permalink / raw)
To: linux-sh
On Mon, Oct 14, 2013 at 06:07:31PM -0700, Kuninori Morimoto wrote:
> Hi Simon again
>
> > > > "The name of a node should be somewhat generic, reflecting the
> > > > function of the device and not its precise programming model." So I
> > > > suggest using "mmc" or "sd" instead.
> > > >
> > > > [1] http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf
> > >
> > > Morimoto-san,
> > >
> > > would it be possible for you to either update this patch or provide a
> > > subsequent incremental to use "mmc" or "sd" as Sergei suggests. I have a
> > > slight preference for "mmc" but please use your own judgement.
> > >
> > > If you could also provide patches to update existing dts/dtsi files
> > > that would be awesome.
> >
> > I see.
> > But, we already have both SDHI and MMCIF now.
> > I guess below naming seems good.
> >
> > - SDHI -> sd
> > - MMCIF -> mmc
> >
> > what do you think ?
Sounds good.
> And, I will send fixup patches for existing dts/dtsi.
> Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> or do you want to me v2 patches for these ?
I'm happy to take your current patches as-is and then apply
naming fixes on top.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
` (4 preceding siblings ...)
2013-10-16 6:09 ` Simon Horman
@ 2013-10-17 2:51 ` Kuninori Morimoto
2013-10-17 4:23 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2013-10-17 2:51 UTC (permalink / raw)
To: linux-sh
Hi Simon
> > And, I will send fixup patches for existing dts/dtsi.
> > Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> > or do you want to me v2 patches for these ?
>
> I'm happy to take your current patches as-is and then apply
> naming fixes on top.
Cool, thank you
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI
2013-10-11 6:35 [PATCH 06/10] ARM: shmobile: r8a7778: add SDHI support on DTSI Kuninori Morimoto
` (5 preceding siblings ...)
2013-10-17 2:51 ` Kuninori Morimoto
@ 2013-10-17 4:23 ` Simon Horman
6 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2013-10-17 4:23 UTC (permalink / raw)
To: linux-sh
On Wed, Oct 16, 2013 at 07:51:56PM -0700, Kuninori Morimoto wrote:
>
> Hi Simon
>
> > > And, I will send fixup patches for existing dts/dtsi.
> > > Then, can you accept these current r8a7778 patches as-is + naming fixup patch ?
> > > or do you want to me v2 patches for these ?
> >
> > I'm happy to take your current patches as-is and then apply
> > naming fixes on top.
>
> Cool, thank you
Btw, I have taken them. Let me know if I am mistaken.
^ permalink raw reply [flat|nested] 8+ messages in thread