From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7779: cleanup registration of VIN
Date: Wed, 16 Oct 2013 07:08:10 +0000 [thread overview]
Message-ID: <20131016070809.GK15425@verge.net.au> (raw)
In-Reply-To: <87ob6rdzg3.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Oct 15, 2013 at 12:12:05PM +0900, Magnus Damm wrote:
> Hi Morimoto-san,
>
> On Tue, Oct 15, 2013 at 11:45 AM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > VIN driver which needs platform data at the time of
> > registration is used from Marzen only.
> > Now, ARM/shmobile aims to support DT,
> > and the C code base board support will be removed
> > if DT support is completed.
> > Current driver registration method which needs platform data
> > and which is not shared complicates codes.
> > This means legacy C code cleanup after DT supporting
> > will be more complicated
> > This patch registers it on board code as cleanup C code
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > This patch is based on renesas-devel-20131011 tag
> >
> > arch/arm/mach-shmobile/board-marzen.c | 24 ++++++++++++++--
> > arch/arm/mach-shmobile/include/mach/r8a7779.h | 2 --
> > arch/arm/mach-shmobile/setup-r8a7779.c | 37 -------------------------
> > 3 files changed, 22 insertions(+), 41 deletions(-)
>
> Thanks for cleaning up the code, Morimoto-san. Fewer lines and also
> device registration in same style as other mach-shmobile SoCs and
> boards, I like that.
>
> Acked-by: Magnus Damm <damm@opensource.se>
Thanks, I have queued this up.
prev parent reply other threads:[~2013-10-16 7:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 2:45 [PATCH] ARM: shmobile: r8a7779: cleanup registration of VIN Kuninori Morimoto
2013-10-15 3:12 ` Magnus Damm
2013-10-16 7:08 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131016070809.GK15425@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).