* [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference
@ 2013-10-16 21:58 Magnus Damm
2013-10-17 1:06 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2013-10-16 21:58 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
Clean up the Lager DT reference board code to make it match
Koelsch DT reference including using the rcar-gen2 header.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Written against renesas-devel-20131016
arch/arm/mach-shmobile/board-lager-reference.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- 0001/arch/arm/mach-shmobile/board-lager-reference.c
+++ work/arch/arm/mach-shmobile/board-lager-reference.c 2013-10-08 15:32:05.000000000 +0900
@@ -20,16 +20,15 @@
#include <linux/init.h>
#include <linux/of_platform.h>
+#include <mach/rcar-gen2.h>
#include <mach/r8a7790.h>
#include <asm/mach/arch.h>
static void __init lager_add_standard_devices(void)
{
- /* clocks are setup late during boot in the case of DT */
r8a7790_clock_init();
-
r8a7790_add_dt_devices();
- of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
+ of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
}
static const char *lager_boards_compat_dt[] __initdata = {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference
2013-10-16 21:58 [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference Magnus Damm
@ 2013-10-17 1:06 ` Simon Horman
2013-10-17 4:53 ` Magnus Damm
0 siblings, 1 reply; 4+ messages in thread
From: Simon Horman @ 2013-10-17 1:06 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 17, 2013 at 06:58:19AM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@opensource.se>
>
> Clean up the Lager DT reference board code to make it match
> Koelsch DT reference including using the rcar-gen2 header.
This is getting dangerously close to churn.
Do you really want me to take this change?
>
> Signed-off-by: Magnus Damm <damm@opensource.se>
> ---
>
> Written against renesas-devel-20131016
>
> arch/arm/mach-shmobile/board-lager-reference.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> --- 0001/arch/arm/mach-shmobile/board-lager-reference.c
> +++ work/arch/arm/mach-shmobile/board-lager-reference.c 2013-10-08 15:32:05.000000000 +0900
> @@ -20,16 +20,15 @@
>
> #include <linux/init.h>
> #include <linux/of_platform.h>
> +#include <mach/rcar-gen2.h>
> #include <mach/r8a7790.h>
> #include <asm/mach/arch.h>
>
> static void __init lager_add_standard_devices(void)
> {
> - /* clocks are setup late during boot in the case of DT */
> r8a7790_clock_init();
> -
> r8a7790_add_dt_devices();
> - of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> }
>
> static const char *lager_boards_compat_dt[] __initdata = {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference
2013-10-17 1:06 ` Simon Horman
@ 2013-10-17 4:53 ` Magnus Damm
2013-10-17 5:28 ` Simon Horman
0 siblings, 1 reply; 4+ messages in thread
From: Magnus Damm @ 2013-10-17 4:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon,
On Thu, Oct 17, 2013 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Oct 17, 2013 at 06:58:19AM +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@opensource.se>
>>
>> Clean up the Lager DT reference board code to make it match
>> Koelsch DT reference including using the rcar-gen2 header.
>
> This is getting dangerously close to churn.
> Do you really want me to take this change?
I don't mind so much, but I think that the idea of keeping Lager and
Koelsch in the same style makes sense. Would you prefer to split this
up in several patches? There is some whitespace damage and also the
header file inclusion style is different from Koelsch.
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference
2013-10-17 4:53 ` Magnus Damm
@ 2013-10-17 5:28 ` Simon Horman
0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2013-10-17 5:28 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 17, 2013 at 01:53:30PM +0900, Magnus Damm wrote:
> Hi Simon,
>
> On Thu, Oct 17, 2013 at 10:06 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Oct 17, 2013 at 06:58:19AM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> Clean up the Lager DT reference board code to make it match
> >> Koelsch DT reference including using the rcar-gen2 header.
> >
> > This is getting dangerously close to churn.
> > Do you really want me to take this change?
>
> I don't mind so much, but I think that the idea of keeping Lager and
> Koelsch in the same style makes sense. Would you prefer to split this
> up in several patches? There is some whitespace damage and also the
> header file inclusion style is different from Koelsch.
I don't think splitting it would improve my level of happiness.
I now accept that the header include change is of some merit
and I'm prepared to take the rest as baggage.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-17 5:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-16 21:58 [PATCH] ARM: shmobile: Cosmetic update of Lager DT Reference Magnus Damm
2013-10-17 1:06 ` Simon Horman
2013-10-17 4:53 ` Magnus Damm
2013-10-17 5:28 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).