From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 01/17] ARM: shmobile: r8a73a4: fixup DT node naming for SDHI
Date: Tue, 29 Oct 2013 04:43:46 +0000 [thread overview]
Message-ID: <20131029044346.GD20432@verge.net.au> (raw)
In-Reply-To: <87hacjdlmi.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Oct 21, 2013 at 05:09:46PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 10/17/2013 06:49 AM, Kuninori Morimoto wrote:
>
> >>>>- sdhi0: sdhi@ee100000 {
> >>>>+ sd0: sd@ee100000 {
>
> >>> Having to change the node names doesn't mean you need to change
> >>>the labels too (and PFC-related node names too). In fact, I think
> >>>the existing labels are better.
>
> >>My, this is tedious.
>
> >>Looking at other dts files I see a lot of entries
> >>of the form "mmcX: mmc@...". And I think that Morimoto-san's patches
> >>are in keeping with that style.
>
> >>On the other hand, I see your point that its much clearer
> >>to use sdhi0 as that is what the hw manuals refer to and
> >>it would allow differentiation with mmcif.
>
> >>So I lean towards Sergei's suggestion being a bit nicer.
>
> >>Morimoto-san, what is your feeling on this?
>
> >I don't know.
> >Actually, I don't have any interesting about
> >this kind of non-technical patches.
>
> >I don't want sending many patches in many times.
> >So, please show me your concretely favored style.
> >like this ?
>
> > sdhi0: sd@ee100000 {
>
> I thought you were asking Simon. Yes, this is the style I'd prefer.
That is fine by me.
Morimoto-san, would you care to refresh the series?
next prev parent reply other threads:[~2013-10-29 4:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 7:44 [PATCH 01/17] ARM: shmobile: r8a73a4: fixup DT node naming for SDHI Kuninori Morimoto
2013-10-15 13:26 ` Sergei Shtylyov
2013-10-16 0:47 ` Simon Horman
2013-10-17 2:49 ` Kuninori Morimoto
2013-10-21 1:55 ` Kuninori Morimoto
2013-10-21 13:09 ` Sergei Shtylyov
2013-10-29 4:43 ` Simon Horman [this message]
2013-10-29 5:16 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029044346.GD20432@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).