From: Simon Horman <horms@verge.net.au>
To: Valentine Barshak <valentine.barshak@cogentembedded.com>
Cc: linux-media@vger.kernel.org,
Hans Verkuil <hans.verkuil@cisco.com>,
Magnus Damm <magnus.damm@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] media: rcar_vin: Add preliminary r8a7790 support
Date: Tue, 29 Oct 2013 05:06:35 +0000 [thread overview]
Message-ID: <20131029050635.GG20432@verge.net.au> (raw)
In-Reply-To: <1380896452-10687-1-git-send-email-valentine.barshak@cogentembedded.com>
On Fri, Oct 04, 2013 at 06:20:52PM +0400, Valentine Barshak wrote:
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
This looks entirely sane to me.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Mauro, would you consider taking this?
> ---
> drivers/media/platform/soc_camera/rcar_vin.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index d02a7e0..b21f777 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> @@ -105,6 +105,7 @@
> #define VIN_MAX_HEIGHT 2048
>
> enum chip_id {
> + RCAR_H2,
> RCAR_H1,
> RCAR_M1,
> RCAR_E1,
> @@ -300,7 +301,8 @@ static int rcar_vin_setup(struct rcar_vin_priv *priv)
> dmr = 0;
> break;
> case V4L2_PIX_FMT_RGB32:
> - if (priv->chip = RCAR_H1 || priv->chip = RCAR_E1) {
> + if (priv->chip = RCAR_H2 || priv->chip = RCAR_H1 ||
> + priv->chip = RCAR_E1) {
> dmr = VNDMR_EXRGB;
> break;
> }
> @@ -1381,6 +1383,7 @@ static struct soc_camera_host_ops rcar_vin_host_ops = {
> };
>
> static struct platform_device_id rcar_vin_id_table[] = {
> + { "r8a7790-vin", RCAR_H2 },
> { "r8a7779-vin", RCAR_H1 },
> { "r8a7778-vin", RCAR_M1 },
> { "uPD35004-vin", RCAR_E1 },
> --
> 1.8.3.1
>
prev parent reply other threads:[~2013-10-29 5:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-04 14:20 [PATCH] media: rcar_vin: Add preliminary r8a7790 support Valentine Barshak
2013-10-29 5:06 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029050635.GG20432@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski@gmx.de \
--cc=hans.verkuil@cisco.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=magnus.damm@gmail.com \
--cc=valentine.barshak@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).