[PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Kuninori Morimoto]

Hi Simon, Max

These patches fixup R-Car HBPDMA driver
for double plane.

Max

Could you please review these patches ?
Especially last patch.
It checks DQSTS when double plane, but I'm not good at HPBDMA.

I tested these patches on my R-Car sound driver in local environment.
It doesn't work without these patches.

Kuninori Morimoto (3):
      rcar-hpbdma: add max transfer size
      rcar-hpbdma: initialise plane information when halted
      rcar-hpbdma: fixup channel busy check for double plane

 drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)


Best regards
---
Kuninori Morimoto

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Max Filippov]

Hi Kuninori,

On Thu, Oct 17, 2013 at 2:50 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Simon, Max
>
> These patches fixup R-Car HBPDMA driver
> for double plane.
>
> Max
>
> Could you please review these patches ?
> Especially last patch.
> It checks DQSTS when double plane, but I'm not good at HPBDMA.
>
> I tested these patches on my R-Car sound driver in local environment.
> It doesn't work without these patches.
>
> Kuninori Morimoto (3):
>       rcar-hpbdma: add max transfer size
>       rcar-hpbdma: initialise plane information when halted
>       rcar-hpbdma: fixup channel busy check for double plane
>
>  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

For the whole series:
Reviewed-by: Max Filippov <max.filippov@cogentembedded.com>

-- 
Thanks.
-- Max

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Kuninori Morimoto]

Hi Simon

These are v2 of R-Car HBPDMA fixup patches
for double plane.

Kuninori Morimoto (3):
      rcar-hpbdma: add max transfer size
      rcar-hpbdma: initialise plane information when halted
      rcar-hpbdma: fixup channel busy check for double plane

 drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Best regards
---
Kuninori Morimoto

[off-list] Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Simon Horman]

Hi Morimoto-san,

as these are dma patches shouldn't they go through (lazy) Vinod?
If so, I'll Ack them ask you to repost them on the ML.

If not, I guess I can set up a branch and see if I can get
them accepted through the arm-soc tree or elsewhere.

On Thu, Oct 17, 2013 at 05:03:54PM -0700, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> These are v2 of R-Car HBPDMA fixup patches
> for double plane.
> 
> Kuninori Morimoto (3):
>       rcar-hpbdma: add max transfer size
>       rcar-hpbdma: initialise plane information when halted
>       rcar-hpbdma: fixup channel busy check for double plane
> 
>  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> Best regards
> ---
> Kuninori Morimoto
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Simon Horman]

Ooops, I responded on-list.

On Tue, Oct 29, 2013 at 02:11:22PM +0900, Simon Horman wrote:
> Hi Morimoto-san,
> 
> as these are dma patches shouldn't they go through (lazy) Vinod?
> If so, I'll Ack them ask you to repost them on the ML.
> 
> If not, I guess I can set up a branch and see if I can get
> them accepted through the arm-soc tree or elsewhere.
> 
> On Thu, Oct 17, 2013 at 05:03:54PM -0700, Kuninori Morimoto wrote:
> > 
> > Hi Simon
> > 
> > These are v2 of R-Car HBPDMA fixup patches
> > for double plane.
> > 
> > Kuninori Morimoto (3):
> >       rcar-hpbdma: add max transfer size
> >       rcar-hpbdma: initialise plane information when halted
> >       rcar-hpbdma: fixup channel busy check for double plane
> > 
> >  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
> >  1 file changed, 9 insertions(+), 1 deletion(-)
> > 
> > Best regards
> > ---
> > Kuninori Morimoto
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

[PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Kuninori Morimoto]

Hi Vinod
Cc: Simon, Max

These patches fixup R-Car HBPDMA driver
for double plane.

I tested these patches on my R-Car sound driver in local environment.
It doesn't work without these patches.

Kuninori Morimoto (3):
      rcar-hpbdma: add max transfer size
      rcar-hpbdma: initialise plane information when halted
      rcar-hpbdma: fixup channel busy check for double plane

 drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)


Best regards
---
Kuninori Morimoto

[PATCH 1/3] rcar-hpbdma: add max transfer size

[Kuninori Morimoto]

shdma_chan_probe() can set max transfer size,
but it will be PAGE_SIZE with out this patch.

Reviewed-by: Max Filippov <max.filippov@cogentembedded.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/dma/sh/rcar-hpbdma.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index ebad845..496180a 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -510,6 +510,8 @@ static int hpb_dmae_chan_probe(struct hpb_dmae_device *hpbdev, int id)
 	}
 
 	schan = &new_hpb_chan->shdma_chan;
+	schan->max_xfer_len = HPB_DMA_TCR_MAX;
+
 	shdma_chan_probe(sdev, schan, id);
 
 	if (pdev->id >= 0)
-- 
1.7.9.5

[PATCH 2/3] rcar-hpbdma: initialise plane information when halted

[Kuninori Morimoto]

Plane information should be initialized when halted.
It may restart from the wrong plane without this patch.

Reviewed-by: Max Filippov <max.filippov@cogentembedded.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/dma/sh/rcar-hpbdma.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index 496180a..19af32d 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -286,6 +286,9 @@ static void hpb_dmae_halt(struct shdma_chan *schan)
 
 	ch_reg_write(chan, HPB_DMAE_DCMDR_DQEND, HPB_DMAE_DCMDR);
 	ch_reg_write(chan, HPB_DMAE_DSTPR_DMSTP, HPB_DMAE_DSTPR);
+
+	chan->plane_idx = 0;
+	chan->first_desc = true;
 }
 
 static const struct hpb_dmae_slave_config *
-- 
1.7.9.5

[PATCH 3/3] rcar-hpbdma: fixup channel busy check for double plane

[Kuninori Morimoto]

The device busy check method is different between
single and double planes.
It will always return "busy" without this patch
if channel used as double plane.

Reviewed-by: Max Filippov <max.filippov@cogentembedded.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 drivers/dma/sh/rcar-hpbdma.c |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/dma/sh/rcar-hpbdma.c b/drivers/dma/sh/rcar-hpbdma.c
index 19af32d..3083d90 100644
--- a/drivers/dma/sh/rcar-hpbdma.c
+++ b/drivers/dma/sh/rcar-hpbdma.c
@@ -60,6 +60,7 @@
 #define HPB_DMAE_DSTPR_DMSTP	BIT(0)
 
 /* DMA status register (DSTSR) bits */
+#define HPB_DMAE_DSTSR_DQSTS	BIT(2)
 #define HPB_DMAE_DSTSR_DMSTS	BIT(0)
 
 /* DMA common registers */
@@ -388,7 +389,10 @@ static bool hpb_dmae_channel_busy(struct shdma_chan *schan)
 	struct hpb_dmae_chan *chan = to_chan(schan);
 	u32 dstsr = ch_reg_read(chan, HPB_DMAE_DSTSR);
 
-	return (dstsr & HPB_DMAE_DSTSR_DMSTS) = HPB_DMAE_DSTSR_DMSTS;
+	if (chan->xfer_mode = XFER_DOUBLE)
+		return dstsr & HPB_DMAE_DSTSR_DQSTS;
+	else
+		return dstsr & HPB_DMAE_DSTSR_DMSTS;
 }
 
 static int
-- 
1.7.9.5

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Simon Horman]

On Mon, Oct 28, 2013 at 11:51:28PM -0700, Kuninori Morimoto wrote:
> 
> Hi Vinod
> Cc: Simon, Max
> 
> These patches fixup R-Car HBPDMA driver
> for double plane.
> 
> I tested these patches on my R-Car sound driver in local environment.
> It doesn't work without these patches.
> 
> Kuninori Morimoto (3):
>       rcar-hpbdma: add max transfer size
>       rcar-hpbdma: initialise plane information when halted
>       rcar-hpbdma: fixup channel busy check for double plane
> 
>  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)

Thanks Morimoto-san,

these all look good to me.

Acked-by: Simon Horman <horms+renesas@verge.net.au>


Vinod, could you consider applying these?

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Kuninori Morimoto]

Hi Vinod
Cc: Simon

Please teach me current status of these patches

> These patches fixup R-Car HBPDMA driver
> for double plane.
> 
> I tested these patches on my R-Car sound driver in local environment.
> It doesn't work without these patches.
> 
> Kuninori Morimoto (3):
>       rcar-hpbdma: add max transfer size
>       rcar-hpbdma: initialise plane information when halted
>       rcar-hpbdma: fixup channel busy check for double plane
> 
>  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> 
> Best regards
> ---
> Kuninori Morimoto


Best regards
---
Kuninori Morimoto

Re: [PATCH 0/3] rcar-hpbdma: fixup patches for double plane

[Vinod Koul]

On Mon, Oct 28, 2013 at 11:51:28PM -0700, Kuninori Morimoto wrote:
> 
> Hi Vinod
> Cc: Simon, Max
> 
> These patches fixup R-Car HBPDMA driver
> for double plane.
> 
> I tested these patches on my R-Car sound driver in local environment.
> It doesn't work without these patches.
Applied, thanks

--
~Vinod

> 
> Kuninori Morimoto (3):
>       rcar-hpbdma: add max transfer size
>       rcar-hpbdma: initialise plane information when halted
>       rcar-hpbdma: fixup channel busy check for double plane
> 
>  drivers/dma/sh/rcar-hpbdma.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> 
> Best regards
> ---
> Kuninori Morimoto

--