From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization
Date: Tue, 29 Oct 2013 05:50:46 +0000 [thread overview]
Message-ID: <20131029055046.GA11580@verge.net.au> (raw)
In-Reply-To: <1382720832-10267-1-git-send-email-valentine.barshak@cogentembedded.com>
On Fri, Oct 25, 2013 at 09:07:12PM +0400, Valentine Barshak wrote:
> Add missing USB UGCTRL2 register offset.
>
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
This seems reasonable to me.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Felipe, please consider applying this change.
> ---
> drivers/usb/phy/phy-rcar-gen2-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
> index a99a695..db3ab34 100644
> --- a/drivers/usb/phy/phy-rcar-gen2-usb.c
> +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
> @@ -107,10 +107,10 @@ static void __rcar_gen2_usb_phy_init(struct rcar_gen2_usb_phy_priv *priv)
> clk_prepare_enable(priv->clk);
>
> /* Set USB channels in the USBHS UGCTRL2 register */
> - val = ioread32(priv->base);
> + val = ioread32(priv->base + USBHS_UGCTRL2_REG);
> val &= ~(USBHS_UGCTRL2_USB0_HS | USBHS_UGCTRL2_USB2_SS);
> val |= priv->ugctrl2;
> - iowrite32(val, priv->base);
> + iowrite32(val, priv->base + USBHS_UGCTRL2_REG);
> }
>
> /* Shutdown USB channels */
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-10-29 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-25 17:07 [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization Valentine Barshak
2013-10-29 5:50 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029055046.GA11580@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).