* [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization
@ 2013-10-25 17:07 Valentine Barshak
2013-10-29 5:50 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Valentine Barshak @ 2013-10-25 17:07 UTC (permalink / raw)
To: linux-sh
Add missing USB UGCTRL2 register offset.
Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
---
drivers/usb/phy/phy-rcar-gen2-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
index a99a695..db3ab34 100644
--- a/drivers/usb/phy/phy-rcar-gen2-usb.c
+++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
@@ -107,10 +107,10 @@ static void __rcar_gen2_usb_phy_init(struct rcar_gen2_usb_phy_priv *priv)
clk_prepare_enable(priv->clk);
/* Set USB channels in the USBHS UGCTRL2 register */
- val = ioread32(priv->base);
+ val = ioread32(priv->base + USBHS_UGCTRL2_REG);
val &= ~(USBHS_UGCTRL2_USB0_HS | USBHS_UGCTRL2_USB2_SS);
val |= priv->ugctrl2;
- iowrite32(val, priv->base);
+ iowrite32(val, priv->base + USBHS_UGCTRL2_REG);
}
/* Shutdown USB channels */
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization
2013-10-25 17:07 [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization Valentine Barshak
@ 2013-10-29 5:50 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-10-29 5:50 UTC (permalink / raw)
To: linux-sh
On Fri, Oct 25, 2013 at 09:07:12PM +0400, Valentine Barshak wrote:
> Add missing USB UGCTRL2 register offset.
>
> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
This seems reasonable to me.
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Felipe, please consider applying this change.
> ---
> drivers/usb/phy/phy-rcar-gen2-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/usb/phy/phy-rcar-gen2-usb.c b/drivers/usb/phy/phy-rcar-gen2-usb.c
> index a99a695..db3ab34 100644
> --- a/drivers/usb/phy/phy-rcar-gen2-usb.c
> +++ b/drivers/usb/phy/phy-rcar-gen2-usb.c
> @@ -107,10 +107,10 @@ static void __rcar_gen2_usb_phy_init(struct rcar_gen2_usb_phy_priv *priv)
> clk_prepare_enable(priv->clk);
>
> /* Set USB channels in the USBHS UGCTRL2 register */
> - val = ioread32(priv->base);
> + val = ioread32(priv->base + USBHS_UGCTRL2_REG);
> val &= ~(USBHS_UGCTRL2_USB0_HS | USBHS_UGCTRL2_USB2_SS);
> val |= priv->ugctrl2;
> - iowrite32(val, priv->base);
> + iowrite32(val, priv->base + USBHS_UGCTRL2_REG);
> }
>
> /* Shutdown USB channels */
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-29 5:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-25 17:07 [PATCH] usb: phy: phy-rcar-gen2-usb: Fix phy initialization Valentine Barshak
2013-10-29 5:50 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).