From: Sebastian Reichel <sre@ring0.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v7 1/5] omap3isp: Modify clocks registration to avoid circular references
Date: Tue, 29 Oct 2013 23:28:39 +0000 [thread overview]
Message-ID: <20131029232837.GB2266@earth.universe> (raw)
In-Reply-To: <16467881.81yEf9zq68@avalon>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
Hi,
On Tue, Oct 29, 2013 at 11:28:37PM +0100, Laurent Pinchart wrote:
> On Tuesday 29 October 2013 20:51:04 Sylwester Nawrocki wrote:
> > The clock core code is going to be modified so clk_get() takes
> > reference on the clock provider module. Until the potential circular
> > reference issue is properly addressed, we pass NULL as as the first
> > argument to clk_register(), in order to disallow sub-devices taking
> > a reference on the ISP module back trough clk_get(). This should
> > prevent locking the modules in memory.
> >
> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Do you plan to push this to mainline as part of this patch series ? I don't
> have pending patches for the omap3isp that would conflict with this patch, so
> that would be fine with me.
I plan to add support for DT to omap3isp + ADP1653 shortly. I have
not yet started to work on this, but expect to send some first RFC
patches in November.
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-10-29 23:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-29 19:51 [PATCH v7 0/5] clk: clock deregistration support Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 1/5] omap3isp: Modify clocks registration to avoid circular references Sylwester Nawrocki
2013-10-29 22:28 ` Laurent Pinchart
2013-10-29 23:28 ` Sebastian Reichel [this message]
2013-10-29 23:55 ` Laurent Pinchart
2013-10-29 23:57 ` Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 2/5] clk: Provide not locked variant of of_clk_get_from_provider() Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 3/5] clkdev: Fix race condition in clock lookup from device tree Sylwester Nawrocki
2013-10-29 19:51 ` [PATCH v7 4/5] clk: Add common __clk_get(), __clk_put() implementations Sylwester Nawrocki
2013-10-30 0:19 ` Russell King - ARM Linux
2013-10-29 19:51 ` [PATCH v7 5/5] clk: Implement clk_unregister() Sylwester Nawrocki
2013-10-31 18:32 ` Stephen Warren
2013-10-31 18:55 ` Sylwester Nawrocki
2013-10-31 19:07 ` Stephen Warren
2013-10-30 19:42 ` [PATCH v7 0/5] clk: clock deregistration support Mike Turquette
2013-11-01 13:56 ` Jonas Jensen
2013-11-01 16:41 ` Sylwester Nawrocki
2013-11-04 8:43 ` Jonas Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131029232837.GB2266@earth.universe \
--to=sre@ring0.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).