From: Simon Horman <horms@verge.net.au>
To: Kumar Gala <galak@codeaurora.org>
Cc: Valentine Barshak <valentine.barshak@cogentembedded.com>,
linux-sh@vger.kernel.org, linux-ide@vger.kernel.org,
devicetree@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Tejun Heo <tj@kernel.org>, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH 2/2] sata_rcar: Add R-Car Gen2 SATA PHY support
Date: Wed, 30 Oct 2013 00:28:47 +0000 [thread overview]
Message-ID: <20131030002847.GL21262@verge.net.au> (raw)
In-Reply-To: <82E941A8-D062-4E90-B661-511881F51F9B@codeaurora.org>
On Tue, Oct 29, 2013 at 12:19:08PM -0500, Kumar Gala wrote:
>
> On Oct 29, 2013, at 3:44 AM, Simon Horman wrote:
>
> > On Tue, Oct 29, 2013 at 03:24:16AM -0500, Kumar Gala wrote:
> >>
> >> On Oct 28, 2013, at 11:59 PM, Simon Horman wrote:
> >>
> >>> On Wed, Oct 16, 2013 at 04:06:01PM +0400, Valentine Barshak wrote:
> >>>> R-Car Gen2 SoCs have a different PHY which is not compatible
> >>>> with the older R-Car H1 (R8A7779) version.
> >>>> This adds OF/platform device id tables and PHY initialization
> >>>> callbacks for the following Gen2 SoCs:
> >>>> * R-Car H2: R8A7790;
> >>>> * R-Car M2: R8A7791.
> >>>>
> >>>> PHY initialization method is chosen based on the device id.
> >>>> Default PHY settings are applied for Gen2 SoCs, which should
> >>>> suit the Gen2 boards available.
> >>>>
> >>>> The R8A7779 platform code is modified to use "sata-r8a7779"
> >>>> device name.
> >>>>
> >>>> Signed-off-by: Valentine Barshak <valentine.barshak@cogentembedded.com>
> >>>> ---
> >>>> .../devicetree/bindings/ata/sata_rcar.txt | 5 +-
> >>>> arch/arm/mach-shmobile/clock-r8a7779.c | 2 +-
> >>>> arch/arm/mach-shmobile/setup-r8a7779.c | 2 +-
> >>>> drivers/ata/sata_rcar.c | 118 ++++++++++++++++++---
> >>>
> >>> Hi Mark, Hi Device-Tree Folks,
> >>>
> >>> I'm wondering if you have had a chance to look over the bindings
> >>> aspect of this and the other patch in the series. I believe that
> >>> this series addresses all previous review in that regards.
> >>
> >> What tree is this binding in?
> >
> > sata_car.txt is added by the previous patch in this series
> > "[PATCH 1/2] sata_rcar: Adjust and document device tree bindings"
>
> Why not just have all the binding in one patch. There isn't a reason this should be split.
I think that the motivation was that the first patch documents the
existing implementation while the second documents a change to it.
With that in mind would you still like a single patch for the binding?
next prev parent reply other threads:[~2013-10-30 0:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-14 15:42 [PATCH 0/2] sata_rcar: Adjust DT bindings and add R-Car Gen2 PHY support Valentine Barshak
2013-10-14 15:42 ` [PATCH 1/2] sata_rcar: Adjust and document device tree bindings Valentine Barshak
2013-10-14 16:13 ` Mark Rutland
2013-10-14 17:19 ` Valentine
2013-10-15 0:25 ` Simon Horman
2013-10-15 8:15 ` Mark Rutland
2013-10-14 15:42 ` [PATCH 2/2] sata_rcar: Add R-Car Gen2 SATA support Valentine Barshak
2013-10-14 16:26 ` Mark Rutland
2013-10-14 17:58 ` Valentine
2013-10-14 18:15 ` Laurent Pinchart
2013-10-14 21:22 ` Valentine
2013-10-15 0:23 ` Simon Horman
2013-10-15 0:32 ` Laurent Pinchart
2013-10-16 6:10 ` Simon Horman
2013-10-15 10:20 ` [PATCH 0/2] sata_rcar: Adjust DT bindings and add R-Car Gen2 PHY support (take 2) Valentine Barshak
2013-10-15 10:20 ` [PATCH 1/2] sata_rcar: Adjust and document device tree bindings Valentine Barshak
2013-10-16 0:42 ` Simon Horman
2013-10-15 10:20 ` [PATCH 2/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-10-15 12:40 ` [PATCH 0/2] sata_rcar: Adjust DT bindings and add R-Car Gen2 PHY support (take 2) Tejun Heo
2013-10-16 12:05 ` [PATCH 0/2] sata_rcar: Adjust DT bindings and add R-Car Gen2 PHY support (take 3) Valentine Barshak
2013-10-16 12:06 ` [PATCH 1/2] sata_rcar: Adjust and document device tree bindings Valentine Barshak
2013-10-16 12:06 ` [PATCH 2/2] sata_rcar: Add R-Car Gen2 SATA PHY support Valentine Barshak
2013-10-29 4:59 ` Simon Horman
2013-10-29 8:24 ` Kumar Gala
2013-10-29 8:44 ` Simon Horman
2013-10-29 17:19 ` Kumar Gala
2013-10-30 0:28 ` Simon Horman [this message]
2013-10-30 7:05 ` Kumar Gala
2013-10-30 17:07 ` Valentine
2013-10-29 8:46 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131030002847.GL21262@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=valentine.barshak@cogentembedded.com \
--cc=vladimir.barinov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).