Re: [PATCH v3] iommu: shmobile: Enable the driver on all ARM platforms

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 989 bytes --]

On Wed, Oct 30, 2013 at 12:40:12PM +0100, Laurent Pinchart wrote:

> > For similar reasons as x86, can we please think about using:

> > 	depends on ARM
> > 	depends on ARCH_SHMOBILE || ARCH_SHMOBILE_MULTI || COMPILE_TEST

> I'm fine with your proposed option. As I don't want to respin the series 
> dozens of time let's first agree on the course of action, I will then repost 
> the patches. Mark, you've pushed towards as few platform dependencies as 
> possible, what's your opinion on this ?

In general I think we should have whatever the real depedencies are or
COMPILE_TEST (to the extent that they will actually build cleanly on
other targets).  That way only people who explicitly go looking to
compile test things for build coverage (eg, when doing global cleanups
or API updates) need to be bothered by the extra compile test options.

I'd read the above as saying the code needs ARM to build at all and that
the hardware will only ever appear on SHMOBILE.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]